Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1311)

Unified Diff: rietveld.py

Issue 10908063: Fix apply_issue.py to work on python 2.6. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index fd00e93ab013b892b654e35c08fe6ed0ca91bbee..ee8f00a879ecf818a797e02e18b8dd3faf8b2df5 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -47,8 +47,12 @@ class Rietveld(object):
extra_headers=extra_headers or {})
else:
if email == '':
+ # If email is given as an empty string, then assume we want to make
+ # requests that do not need authentication. Bypass authentication by
+ # setting the flag to True.
get_creds = lambda: (email, None)
self.rpc_server = upload.HttpRpcServer(url, get_creds)
+ self.rpc_server.authenticated = True
M-A Ruel 2012/09/03 17:34:25 My fault in removing it in r154696.
Roger Tawa OOO till Jul 10th 2012/09/04 13:48:31 :-) I thought you had figured out a better way to
M-A Ruel 2012/09/04 17:36:29 No, it still did prompts without it. :/
else:
self.rpc_server = upload.GetRpcServer(url, email)

Powered by Google App Engine
This is Rietveld 408576698