Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: test/mjsunit/object-define-property.js

Issue 10907254: Tentatively reenable previous failing test. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1038 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 1049
1050 // Regression test: Ensure that growing dictionaries are not ignored. 1050 // Regression test: Ensure that growing dictionaries are not ignored.
1051 o = {}; 1051 o = {};
1052 for (var i = 0; i < 1000; i++) { 1052 for (var i = 0; i < 1000; i++) {
1053 // Non-enumerable property forces dictionary mode. 1053 // Non-enumerable property forces dictionary mode.
1054 Object.defineProperty(o, i, {value: i, enumerable: false}); 1054 Object.defineProperty(o, i, {value: i, enumerable: false});
1055 } 1055 }
1056 assertEquals(999, o[999]); 1056 assertEquals(999, o[999]);
1057 1057
1058 1058
1059 // Regression test: Bizzare behavior on non-strict arguments object.
Michael Starzinger 2012/09/17 14:15:56 Can we keep the original comment?
1060 // TODO(yangguo): Tests disabled, needs investigation!
1061 /*
1062 (function test(arg0) { 1059 (function test(arg0) {
1063 // Here arguments[0] is a fast alias on arg0. 1060 // Here arguments[0] is a fast alias on arg0.
1064 Object.defineProperty(arguments, "0", { 1061 Object.defineProperty(arguments, "0", {
1065 value:1, 1062 value:1,
1066 enumerable:false 1063 enumerable:false
1067 }); 1064 });
1068 // Here arguments[0] is a slow alias on arg0. 1065 // Here arguments[0] is a slow alias on arg0.
1069 Object.defineProperty(arguments, "0", { 1066 Object.defineProperty(arguments, "0", {
1070 value:2, 1067 value:2,
1071 writable:false 1068 writable:false
1072 }); 1069 });
1073 // Here arguments[0] is no alias at all. 1070 // Here arguments[0] is no alias at all.
1074 Object.defineProperty(arguments, "0", { 1071 Object.defineProperty(arguments, "0", {
1075 value:3 1072 value:3
1076 }); 1073 });
1077 assertEquals(2, arg0); 1074 assertEquals(2, arg0);
1078 assertEquals(3, arguments[0]); 1075 assertEquals(3, arguments[0]);
1079 })(0); 1076 })(0);
1080 */ 1077
1081 1078
1082 // Regression test: We should never observe the hole value. 1079 // Regression test: We should never observe the hole value.
1083 var objectWithGetter = {}; 1080 var objectWithGetter = {};
1084 objectWithGetter.__defineGetter__('foo', function() {}); 1081 objectWithGetter.__defineGetter__('foo', function() {});
1085 assertEquals(undefined, objectWithGetter.__lookupSetter__('foo')); 1082 assertEquals(undefined, objectWithGetter.__lookupSetter__('foo'));
1086 1083
1087 var objectWithSetter = {}; 1084 var objectWithSetter = {};
1088 objectWithSetter.__defineSetter__('foo', function(x) {}); 1085 objectWithSetter.__defineSetter__('foo', function(x) {});
1089 assertEquals(undefined, objectWithSetter.__lookupGetter__('foo')); 1086 assertEquals(undefined, objectWithSetter.__lookupGetter__('foo'));
1090 1087
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 o.blubb = 123; 1180 o.blubb = 123;
1184 } 1181 }
1185 1182
1186 function C() {} 1183 function C() {}
1187 1184
1188 Assign(new C); 1185 Assign(new C);
1189 Assign(new C); 1186 Assign(new C);
1190 %OptimizeFunctionOnNextCall(Assign); 1187 %OptimizeFunctionOnNextCall(Assign);
1191 Object.defineProperty(C.prototype, "blubb", {get: function() { return -42; }}); 1188 Object.defineProperty(C.prototype, "blubb", {get: function() { return -42; }});
1192 Assign(new C); 1189 Assign(new C);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698