Issue 10907197: Differentiate between tests that needs to be run or need to wait for completion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10907197: Differentiate between tests that needs to be run or need to wait for completion. (Closed)

Created:
8 years, 3 months ago by M-A Ruel

Modified:
8 years, 3 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one), cmp+cc_chromium.org, Isaac (away)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Visibility:
Public.

More Reviews

Description

Differentiate between tests that needs to be run or need to wait for completion. This should fix weirdo behavior in the commit queue. Create RietveldTryJobPending object to make RietveldTryJobs.pendings more sensible. Add unit tests to confirm the behavior. R=rogerta@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156312

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+186 lines, -43 lines)			Patch
	M	tests/try_job_on_rietveld_test.py	View		11 chunks	+128 lines, -19 lines	0 comments	Download
	M	verification/try_job_on_rietveld.py	View		9 chunks	+58 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10907197/1

8 years, 3 months ago (2012-09-12 16:41:12 UTC) #3

Change committed as 156312

Expand Messages | Collapse Messages