Extensions Docs Server: Enum values do not show up if enum is a type

tools/json_schema_compiler/cc_generator.py

Index: tools/json_schema_compiler/cc_generator.py
diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py
index f01479a2f612bb6c41b48a785a9de8898224ced0..f5452d727803a4dc3163c65f7082a3795f568012 100644
--- a/tools/json_schema_compiler/cc_generator.py
+++ b/tools/json_schema_compiler/cc_generator.py
@@ -749,11 +749,11 @@ class CCGenerator(object):
           '%s_%s' % (classname.upper(), enum_value.upper()),
           'scoped_ptr<base::Value>(base::Value::CreateStringValue("%s"))' %
           enum_value))
-    (c.Eblock('}')
-      .Append('NOTREACHED();')
-      .Append('return scoped_ptr<base::Value>();')
-      .Eblock('}')
-    )
+    (c.Append('default:')
+     .Append('  NOTREACHED();')

[not at google - send to devlin, 2012/09/11 23:07:43]

is this necessary?

[cduvall, 2012/09/11 23:10:38]

I just had it because that's what used to be there. It looks like there's more
problems around though, its still not compiling.

[not at google - send to devlin, 2012/09/11 23:14:09]

Used to be there when?

[cduvall, 2012/09/11 23:18:28]

Were you talking about the NOTREACHED or the default case? The default case was
needed to handle the *_NONE enum value, because I got a compile error that the
switch case didn't handle it.

The problem is that normally an enum will only have a *_NONE value if it is
optional, but when an enum is a type, you can't know if its going to be optional
or not.

[not at google - send to devlin, 2012/09/11 23:19:52]

Yeah, the thing abou the default case vs the fall-through. That makes sense
though. Could you add a comment here explaining that?

+     .Eblock('}')
+     .Append('return scoped_ptr<base::Value>();')
+     .Eblock('}'))
     return c
 
   # TODO(chebert): This is basically the same as GenerateCreateEnumTypeValue().