Extensions Docs Server: Enum values do not show up if enum is a type

tools/json_schema_compiler/cc_generator.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from code import Code
 from model import PropertyType
 import any_helper
 import cpp_util
 import model
 import schema_util
@@ skipping 731 matching lines @@
     c.Sblock('scoped_ptr<base::Value> CreateEnumValue(%s %s) {' % (
         classname, classname.lower()))
     c.Sblock('switch (%s) {' % classname.lower())
 
     enum_prop = self._cpp_type_generator.GetReferencedProperty(prop)
     for enum_value in enum_prop.enum_values:
       c.Concat(self._GenerateReturnCase(
           '%s_%s' % (classname.upper(), enum_value.upper()),
           'scoped_ptr<base::Value>(base::Value::CreateStringValue("%s"))' %
           enum_value))
-    (c.Eblock('}')
-      .Append('NOTREACHED();')
-      .Append('return scoped_ptr<base::Value>();')
-      .Eblock('}')
-    )
+    (c.Append('default:')
+     .Append('  NOTREACHED();')

[not at google - send to devlin, 2012/09/11 23:07:43]

is this necessary?

[cduvall, 2012/09/11 23:10:38]

I just had it because that's what used to be there. It looks like there's more
problems around though, its still not compiling.

[not at google - send to devlin, 2012/09/11 23:14:09]

Used to be there when?

[cduvall, 2012/09/11 23:18:28]

Were you talking about the NOTREACHED or the default case? The default case was
needed to handle the *_NONE enum value, because I got a compile error that the
switch case didn't handle it.

The problem is that normally an enum will only have a *_NONE value if it is
optional, but when an enum is a type, you can't know if its going to be optional
or not.

[not at google - send to devlin, 2012/09/11 23:19:52]

Yeah, the thing abou the default case vs the fall-through. That makes sense
though. Could you add a comment here explaining that?

+     .Eblock('}')
+     .Append('return scoped_ptr<base::Value>();')
+     .Eblock('}'))
     return c
 
   # TODO(chebert): This is basically the same as GenerateCreateEnumTypeValue().
   # The plan is to phase out the old-style enums, and make all enums into REF
   # types.
   def _GenerateCreateEnumValue(self, cpp_namespace, prop):
     """Generates CreateEnumValue() that returns the base::StringValue
     representation of an enum.
     """
     c = Code()
@@ skipping 131 matching lines @@
     """
     return (self._cpp_type_generator.GetReferencedProperty(prop).type_ ==
         PropertyType.ARRAY)
 
   def _IsFundamentalOrFundamentalRef(self, prop):
     """Determines if this property is a Fundamental type or is a ref to a
     Fundamental type.
     """
     return (self._cpp_type_generator.GetReferencedProperty(prop).type_.
         is_fundamental)