Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Unified Diff: chrome/browser/performance_monitor/startup_timer.cc

Issue 10907121: Add guards to metric values; erase bad events/metrics from db (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_use_units
Patch Set: Estade's requests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/startup_timer.cc
diff --git a/chrome/browser/performance_monitor/startup_timer.cc b/chrome/browser/performance_monitor/startup_timer.cc
index 0af0a57bdc54d92a668c76a2a56619112427679e..c6e581662062fbccb89e6f4d486111db0fd87b72 100644
--- a/chrome/browser/performance_monitor/startup_timer.cc
+++ b/chrome/browser/performance_monitor/startup_timer.cc
@@ -21,9 +21,8 @@ namespace performance_monitor {
namespace {
// Needed because Database::AddMetric is overloaded, so base::Bind doesn't work.
void AddMetricToDatabaseOnBackgroundThread(Database* database,
- MetricType metric,
- std::string value) {
- database->AddMetric(metric, value);
+ Metric metric) {
+ database->AddMetric(metric);
}
} // namespace
@@ -114,9 +113,11 @@ void StartupTimer::InsertElapsedStartupTime() {
base::Bind(
&AddMetricToDatabaseOnBackgroundThread,
base::Unretained(PerformanceMonitor::GetInstance()->database()),
- startup_type_ == STARTUP_NORMAL ? METRIC_STARTUP_TIME
- : METRIC_TEST_STARTUP_TIME,
- base::Int64ToString(elapsed_startup_time_.ToInternalValue())));
+ Metric(startup_type_ == STARTUP_NORMAL ? METRIC_STARTUP_TIME
+ : METRIC_TEST_STARTUP_TIME,
+ base::Time::Now(),
+ static_cast<double>(
+ elapsed_startup_time_.ToInternalValue()))));
}
void StartupTimer::InsertElapsedSessionRestoreTime() {
@@ -129,8 +130,9 @@ void StartupTimer::InsertElapsedSessionRestoreTime() {
base::Bind(
&AddMetricToDatabaseOnBackgroundThread,
base::Unretained(PerformanceMonitor::GetInstance()->database()),
- METRIC_SESSION_RESTORE_TIME,
- base::Int64ToString(iter->ToInternalValue())));
+ Metric(METRIC_SESSION_RESTORE_TIME,
+ base::Time::Now(),
+ static_cast<double>(iter->ToInternalValue()))));
}
}

Powered by Google App Engine
This is Rietveld 408576698