Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: chrome/browser/performance_monitor/performance_monitor.cc

Issue 10907121: Add guards to metric values; erase bad events/metrics from db (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_use_units
Patch Set: Estade's requests Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/performance_monitor.cc
diff --git a/chrome/browser/performance_monitor/performance_monitor.cc b/chrome/browser/performance_monitor/performance_monitor.cc
index effe47037faf8291af004ef279f04c8245073596..d9fee3f38150530415bca0697c78965529f06e03 100644
--- a/chrome/browser/performance_monitor/performance_monitor.cc
+++ b/chrome/browser/performance_monitor/performance_monitor.cc
@@ -278,10 +278,9 @@ void PerformanceMonitor::AddEventOnBackgroundThread(scoped_ptr<Event> event) {
database_->AddEvent(*event.get());
}
-void PerformanceMonitor::AddMetricOnBackgroundThread(MetricType type,
- const std::string& value) {
+void PerformanceMonitor::AddMetricOnBackgroundThread(Metric metric) {
DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
- database_->AddMetric(type, value);
+ database_->AddMetric(metric);
}
void PerformanceMonitor::NotifyInitialized() {
@@ -312,7 +311,9 @@ void PerformanceMonitor::GatherCPUUsageOnBackgroundThread() {
cpu_usage += iter->second->GetCPUUsage();
}
- database_->AddMetric(METRIC_CPU_USAGE, base::DoubleToString(cpu_usage));
+ database_->AddMetric(Metric(METRIC_CPU_USAGE,
+ base::Time::Now(),
+ cpu_usage));
}
}
@@ -331,10 +332,12 @@ void PerformanceMonitor::GatherMemoryUsageOnBackgroundThread() {
}
}
- database_->AddMetric(METRIC_PRIVATE_MEMORY_USAGE,
- base::Uint64ToString(private_memory_sum));
- database_->AddMetric(METRIC_SHARED_MEMORY_USAGE,
- base::Uint64ToString(shared_memory_sum));
+ database_->AddMetric(Metric(METRIC_PRIVATE_MEMORY_USAGE,
+ base::Time::Now(),
+ static_cast<double>(private_memory_sum)));
+ database_->AddMetric(Metric(METRIC_SHARED_MEMORY_USAGE,
+ base::Time::Now(),
+ static_cast<double>(shared_memory_sum)));
}
void PerformanceMonitor::UpdateMetricsMapOnBackgroundThread() {
@@ -432,8 +435,10 @@ void PerformanceMonitor::InsertIOData(
PerformanceDataForIOThread performance_data_for_io_thread) {
CHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
database_->AddMetric(
- METRIC_NETWORK_BYTES_READ,
- base::Uint64ToString(performance_data_for_io_thread.network_bytes_read));
+ Metric(METRIC_NETWORK_BYTES_READ,
+ base::Time::Now(),
+ static_cast<double>(
+ performance_data_for_io_thread.network_bytes_read)));
}
void PerformanceMonitor::BytesReadOnIOThread(const net::URLRequest& request,
@@ -521,8 +526,10 @@ void PerformanceMonitor::Observe(int type,
base::Bind(
&PerformanceMonitor::AddMetricOnBackgroundThread,
base::Unretained(this),
- METRIC_PAGE_LOAD_TIME,
- base::Int64ToString(load_details->load_time.ToInternalValue())));
+ Metric(METRIC_PAGE_LOAD_TIME,
+ base::Time::Now(),
+ static_cast<double>(
+ load_details->load_time.ToInternalValue()))));
break;
}
default: {
« no previous file with comments | « chrome/browser/performance_monitor/performance_monitor.h ('k') | chrome/browser/performance_monitor/startup_timer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698