Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 10907098: Revert 155218 - Move gpu blacklist to content side. (Closed)

Created:
8 years, 3 months ago by benjhayden
Modified:
8 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 155218 - Move gpu blacklist to content side. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/6902/steps/browser_tests/logs/stdio FAILED (3): GpuFeatureTest.AcceleratedCompositingBlocked FAILED (5): GpuFeatureTest.WebGLBlocked FAILED (7): GpuFeatureTest.MultisamplingBlocked FAILED (9): GpuFeatureTest.Canvas2DBlocked chrome/test/gpu/gpu_feature_browsertest.cc:343: Failure Value of: content::GPU_FEATURE_TYPE_ACCELERATED_2D_CANVAS Actual: 1 Expected: type Which is: 0 chrome/test/gpu/gpu_feature_browsertest.cc:133: Failure Value of: size_t(0) Actual: 0 Expected: analyzer_->FindEvents(Query::EventName() == Query::String("SwapBuffers"), &events) Which is: 3 chrome/test/gpu/gpu_feature_browsertest.cc:290: Failure Value of: content::GPU_FEATURE_TYPE_MULTISAMPLING Actual: 8 Expected: type Which is: 0 When it's on the content side, it can be part of the GpuDataManager, so we don't need to make it a Singleton. Also, this CL did some cleanup related to this moving. The main reason for this refactoring is because blacklist is tightly coupled with GpuDataManager. Putting them on the this side makes it much easier to test the code, and the design is much better. BUG= TEST=bots Review URL: https://chromiumcodereview.appspot.com/10908110 TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -3453 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 4 chunks +22 lines, -3 lines 0 comments Download
D chrome/browser/chrome_gpu_util.h View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/chrome_gpu_util.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 2 chunks +6 lines, -1 line 0 comments Download
A + chrome/browser/gpu_blacklist.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/gpu_blacklist.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/gpu_blacklist_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/gpu_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/gpu_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/gpu_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 6 chunks +5 lines, -326 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 8 chunks +46 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 2 chunks +5 lines, -1 line 0 comments Download
D content/browser/gpu/gpu_blacklist.h View 1 chunk +0 lines, -401 lines 0 comments Download
D content/browser/gpu/gpu_blacklist.cc View 1 chunk +0 lines, -1164 lines 0 comments Download
D content/browser/gpu/gpu_blacklist_unittest.cc View 1 chunk +0 lines, -984 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 5 chunks +6 lines, -17 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 6 chunks +9 lines, -40 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
D content/browser/gpu/gpu_util.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/gpu/gpu_util.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D content/browser/gpu/gpu_util_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
benjhayden
8 years, 3 months ago (2012-09-06 19:27:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698