Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 10908110: Move gpu blacklist to content side. (Closed)

Created:
8 years, 3 months ago by Zhenyao Mo
Modified:
8 years, 3 months ago
Reviewers:
jbates
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Move gpu blacklist to content side. When it's on the content side, it can be part of the GpuDataManager, so we don't need to make it a Singleton. Also, this CL did some cleanup related to this moving. The main reason for this refactoring is because blacklist is tightly coupled with GpuDataManager. Putting them on the this side makes it much easier to test the code, and the design is much better. BUG= TEST=bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155218

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+627 lines, -4007 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 4 chunks +3 lines, -22 lines 0 comments Download
A chrome/browser/chrome_gpu_util.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/chrome_gpu_util.cc View 1 1 chunk +123 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 2 chunks +1 line, -6 lines 0 comments Download
D chrome/browser/gpu_blacklist.h View 1 chunk +0 lines, -416 lines 0 comments Download
D chrome/browser/gpu_blacklist.cc View 1 chunk +0 lines, -1188 lines 0 comments Download
D chrome/browser/gpu_blacklist_unittest.cc View 1 chunk +0 lines, -985 lines 0 comments Download
D chrome/browser/gpu_util.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/gpu_util.cc View 1 chunk +0 lines, -631 lines 0 comments Download
D chrome/browser/gpu_util_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 6 chunks +326 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 8 chunks +3 lines, -46 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_feature_browsertest.cc View 2 chunks +1 line, -5 lines 0 comments Download
A + content/browser/gpu/gpu_blacklist.h View 1 2 9 chunks +11 lines, -26 lines 0 comments Download
A + content/browser/gpu/gpu_blacklist.cc View 5 chunks +4 lines, -28 lines 0 comments Download
A + content/browser/gpu/gpu_blacklist_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 5 chunks +17 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 6 chunks +40 lines, -9 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + content/browser/gpu/gpu_util.h View 1 2 2 chunks +13 lines, -50 lines 0 comments Download
A + content/browser/gpu/gpu_util.cc View 7 chunks +8 lines, -416 lines 0 comments Download
A + content/browser/gpu/gpu_util_unittest.cc View 4 chunks +31 lines, -8 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Please review.
8 years, 3 months ago (2012-09-05 23:22:13 UTC) #1
jbates
LGTM with nits https://chromiumcodereview.appspot.com/10908110/diff/1033/content/browser/gpu/gpu_data_manager_impl.cc File content/browser/gpu/gpu_data_manager_impl.cc (left): https://chromiumcodereview.appspot.com/10908110/diff/1033/content/browser/gpu/gpu_data_manager_impl.cc#oldcode64 content/browser/gpu/gpu_data_manager_impl.cc:64: switches::kSkipGpuDataLoading)) Just making sure you meant ...
8 years, 3 months ago (2012-09-06 00:50:41 UTC) #2
Zhenyao Mo
https://chromiumcodereview.appspot.com/10908110/diff/1033/content/browser/gpu/gpu_data_manager_impl.cc File content/browser/gpu/gpu_data_manager_impl.cc (left): https://chromiumcodereview.appspot.com/10908110/diff/1033/content/browser/gpu/gpu_data_manager_impl.cc#oldcode64 content/browser/gpu/gpu_data_manager_impl.cc:64: switches::kSkipGpuDataLoading)) On 2012/09/06 00:50:41, jbates wrote: > Just making ...
8 years, 3 months ago (2012-09-06 00:59:45 UTC) #3
sadrul
8 years, 3 months ago (2012-09-06 19:48:13 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698