Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10907093: Gracefully deal with clearing content settings for unregistered extensions. (Closed)

Created:
8 years, 3 months ago by Bernhard Bauer
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Gracefully deal with clearing content settings for unregistered extensions. BUG=128652 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_store.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Bernhard Bauer
Please review.
8 years, 3 months ago (2012-09-06 13:49:55 UTC) #1
markusheintz_
LGTM
8 years, 3 months ago (2012-09-06 14:36:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10907093/1
8 years, 3 months ago (2012-09-06 15:17:59 UTC) #3
commit-bot: I haz the power
Presubmit check for 10907093-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-06 15:18:01 UTC) #4
Bernhard Bauer
Could I get an OWNERS review? Thanks!
8 years, 3 months ago (2012-09-06 17:13:06 UTC) #5
not at google - send to devlin
lgtm
8 years, 3 months ago (2012-09-06 22:55:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10907093/1
8 years, 3 months ago (2012-09-06 23:01:04 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 06:27:27 UTC) #8
Change committed as 155341

Powered by Google App Engine
This is Rietveld 408576698