Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: chrome/browser/extensions/api/content_settings/content_settings_store.cc

Issue 10907093: Gracefully deal with clearing content settings for unregistered extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/content_settings/content_settings_store.cc
diff --git a/chrome/browser/extensions/api/content_settings/content_settings_store.cc b/chrome/browser/extensions/api/content_settings/content_settings_store.cc
index 84408d99a29a9892d27644a4f02c53fd71cf54f0..37a1f15212df338e8b981a9b576e9e38124aba48 100644
--- a/chrome/browser/extensions/api/content_settings/content_settings_store.cc
+++ b/chrome/browser/extensions/api/content_settings/content_settings_store.cc
@@ -229,14 +229,10 @@ void ContentSettingsStore::ClearContentSettingsForExtension(
{
base::AutoLock lock(lock_);
OriginIdentifierValueMap* map = GetValueMap(ext_id, scope);
- // TODO(bauerb): This is for debugging http://crbug.com/128652.
- // Remove once the bug is fixed.
if (!map) {
- char ext_id_buffer[33];
- base::strlcpy(ext_id_buffer, ext_id.c_str(), sizeof(ext_id_buffer));
- base::debug::Alias(ext_id_buffer);
- // Do a clean crash.
- CHECK(false);
+ // Fail gracefully in Release builds.
+ NOTREACHED();
+ return;
}
notify = !map->empty();
map->clear();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698