Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10905304: Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. (Closed)

Created:
8 years, 3 months ago by Bernhard Bauer
Modified:
8 years, 2 months ago
Reviewers:
CC:
chromium-reviews, tfarina, Avi (use Gerrit), creis+watch_chromium.org, oshima+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. TBR=sky@chromium.org,jam@chromium.org,avi@chromium.org BUG=140474

Patch Set 1 #

Patch Set 2 : sync #

Patch Set 3 : sync #

Patch Set 4 : , #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -64 lines) Patch
M chrome/browser/ui/pdf/open_pdf_in_reader_prompt_delegate.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_tab_helper.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 2 3 10 chunks +60 lines, -62 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10905304/10001
8 years, 3 months ago (2012-09-17 20:00:49 UTC) #1
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 3 months ago (2012-09-17 20:08:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10905304/8003
8 years, 3 months ago (2012-09-17 20:13:34 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-17 20:41:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10905304/8003
8 years, 3 months ago (2012-09-17 20:54:53 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-17 23:41:14 UTC) #6 
Couldn't make sense out of svn commit message:
Sending        chrome/app/generated_resources.grd
Sending        chrome/app/theme/theme_resources.grd
Sending        chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
Sending        chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
Sending        chrome/browser/ui/gtk/location_bar_view_gtk.cc
Sending        chrome/browser/ui/gtk/location_bar_view_gtk.h
Sending        chrome/browser/ui/omnibox/location_bar.h
Adding         chrome/browser/ui/pdf/open_pdf_in_reader_prompt_delegate.h
Adding         chrome/browser/ui/pdf/pdf_tab_helper.cc
Adding         chrome/browser/ui/pdf/pdf_tab_helper.h
Deleting       chrome/browser/ui/pdf/pdf_tab_observer.cc
Deleting       chrome/browser/ui/pdf/pdf_tab_observer.h
Sending        chrome/browser/ui/pdf/pdf_unsupported_feature.cc
Sending        chrome/browser/ui/pdf/pdf_unsupported_feature.h
Sending        chrome/browser/ui/tab_contents/tab_contents.cc
Sending        chrome/browser/ui/tab_contents/tab_contents.h
Sending        chrome/browser/ui/views/location_bar/content_setting_image_view.h
Sending        chrome/browser/ui/views/location_bar/location_bar_view.cc
Sending        chrome/browser/ui/views/location_bar/location_bar_view.h
Adding         chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
Adding         chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h
Adding         chrome/browser/ui/views/open_pdf_in_reader_bubble_view.cc
Adding         chrome/browser/ui/views/open_pdf_in_reader_bubble_view.h
Sending        chrome/chrome_browser_ui.gypi
Sending        chrome/test/base/test_location_bar.h
Transmitting file data .......................
Committed revision 157242.

Warning: post-commit hook failed (exit code 2) with output:
/opt/shared_hooks/post-commit.d/10_mailer.py:137: DeprecationWarning: The popen2
module is deprecated.  Use the subprocess module.
  import popen2
Post-commit mail timed out for r157242. Your commit succeeded,
but no mail was sent.

Powered by Google App Engine
This is Rietveld 408576698