chrome/browser/ui/pdf/pdf_tab_helper.cc - Issue 10905304: Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_tab_helper.cc

Issue 10905304: Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: , Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/pdf/open_pdf_in_reader_prompt_delegate.h ('k') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/pdf/pdf_tab_helper.cc

diff --git a/chrome/browser/ui/pdf/pdf_tab_helper.cc b/chrome/browser/ui/pdf/pdf_tab_helper.cc

index 5b4ad47778daeca0d900f72737b98431bbeac6fa..d62bfd04d635319e9bdd705d9d580814f8e0aace 100644

--- a/chrome/browser/ui/pdf/pdf_tab_helper.cc

+++ b/chrome/browser/ui/pdf/pdf_tab_helper.cc

@@ -41,8 +41,8 @@ bool PDFTabHelper::OnMessageReceived(const IPC::Message& message) {

void PDFTabHelper::DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) {

- if (!details.is_in_page) {

- // Clear "blocked" flags.

+ if (open_in_reader_prompt_.get() &&

+ open_in_reader_prompt_->ShouldExpire(details)) {

open_in_reader_prompt_.reset();

UpdateLocationBar();

}

« no previous file with comments | « chrome/browser/ui/pdf/open_pdf_in_reader_prompt_delegate.h ('k') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('j') | no next file with comments »