Issue 10905100: Ensure that include paths used by webkit_compositor_bindings work in WebKit as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905100: Ensure that include paths used by webkit_compositor_bindings work in WebKit as well. (Closed)

Created:
8 years, 3 months ago by Peter Beverloo

Modified:
8 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure that include paths used by webkit_compositor_bindings work in WebKit as well. BUG= TEST=Both Chromium as WebKit compiles succeed.

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -13 lines)			Patch
M	webkit/compositor_bindings/compositor_bindings.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/compositor_bindings/web_compositor_support_impl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/compositor_bindings/web_compositor_support_impl.cc	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Beverloo

This would work as a build fix, though probably isn't the right way to fix ...

8 years, 3 months ago (2012-09-05 15:11:06 UTC) #1

jamesr

8 years, 3 months ago (2012-09-05 16:08:05 UTC) #2

On 2012/09/05 15:11:06, Peter Beverloo wrote:
> This would work as a build fix, though probably isn't the right way to fix
this
> issue. Feel free to take over.

You shouldn't need to do anything except perhaps tweak the webkit_glue include
path - definitely don't touch source files.  For instance, on my mac in a
chromium-inside-WebKit:

$ ls
out/Debug/gen/webkit/third_party/WebKit/Source/Platform/chromium/public/WebLayer.h

Expand Messages | Collapse Messages