Exempt status bubble windows from status bar darkening

Exempt status bubble windows from status bar darkening


BUG=139936
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154890

[sky, 2012-09-04 20:16:05]

https://chromiumcodereview.appspot.com/10905080/diff/2001/chrome/browser/ui/v...
File chrome/browser/ui/views/frame/browser_view_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10905080/diff/2001/chrome/browser/ui/v...
chrome/browser/ui/views/frame/browser_view_browsertest.cc:43:
IN_PROC_BROWSER_TEST_F(BrowserViewTest, StatusBubble) {
Is it possible to make this a unit test? By that I mean create a status bubble
directly and make sure the property is set?

[DaveMoore, 2012-09-04 23:48:22]

Instead of making a unittest I made the browsertest more interesting by
confirming that a visible statusbubble doesn't trigger the darkening, which was
the original bug.

[sky, 2012-09-05 00:11:45]

LGTM

https://chromiumcodereview.appspot.com/10905080/diff/5001/chrome/browser/ui/a...
File chrome/browser/ui/ash/shelf_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10905080/diff/5001/chrome/browser/ui/a...
chrome/browser/ui/ash/shelf_browsertest.cc:4: #include
"chrome/test/base/in_process_browser_test.h"
Put this with the rest of the includes and sort.

In a test your first include should be the .h you're testing. Since there isn't
really one here, don't try to special case anything.

[commit-bot: I haz the power, 2012-09-05 01:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/10905080/6013

[commit-bot: I haz the power, 2012-09-05 03:29:18]

Change committed as 154890