Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: ash/wm/workspace/workspace_manager2_unittest.cc

Issue 10905080: Exempt status bubble windows from status bar darkening (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review nit Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_manager2.cc ('k') | ash/wm/workspace/workspace_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_manager2_unittest.cc
diff --git a/ash/wm/workspace/workspace_manager2_unittest.cc b/ash/wm/workspace/workspace_manager2_unittest.cc
index f337f7fa4d351b49207af09b4ea8f2edee1dae85..3ec6793963b8419a2a1cc3c40fca2b58c8950c74 100644
--- a/ash/wm/workspace/workspace_manager2_unittest.cc
+++ b/ash/wm/workspace/workspace_manager2_unittest.cc
@@ -468,6 +468,13 @@ TEST_F(WorkspaceManager2Test, ShelfStateUpdated) {
w1->SetBounds(touches_shelf_bounds);
EXPECT_FALSE(GetWindowOverlapsShelf());
+ // A visible ignored window should not trigger the overlap.
+ scoped_ptr<Window> w_ignored(CreateTestWindow());
+ w_ignored->SetBounds(touches_shelf_bounds);
+ SetIgnoredByShelf(&(*w_ignored), true);
+ w_ignored->Show();
+ EXPECT_FALSE(GetWindowOverlapsShelf());
+
// Make it visible, since visible shelf overlaps should be true.
w1->Show();
EXPECT_TRUE(GetWindowOverlapsShelf());
« no previous file with comments | « ash/wm/workspace/workspace_manager2.cc ('k') | ash/wm/workspace/workspace_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698