Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/common/extensions/extension.h

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable unittest on android Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 55e8d2ab319feccc5b26c2d492ee9ffc39f7fefe..d0aef2a9b261103feb8e78ebfd44b6f9954c5705 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -629,8 +629,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
return !omnibox_keyword().empty() ||
browser_action() ||
(page_action() &&
- (page_action_command() ||
- !page_action()->default_icon_path().empty()));
+ (page_action_command() || page_action()->default_icon()));
}
const FileBrowserHandlerList* file_browser_handlers() const {
return file_browser_handlers_.get();
« no previous file with comments | « chrome/common/extensions/docs/templates/intros/pageAction.html ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698