Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/common/extensions/docs/templates/intros/pageAction.html

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable unittest on android Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/templates/intros/pageAction.html
diff --git a/chrome/common/extensions/docs/templates/intros/pageAction.html b/chrome/common/extensions/docs/templates/intros/pageAction.html
index 86930f1715fe78be0d05c662fc3ff0559d97d957..c490abf54e4862fcfa8eeddcdf35f1064250c43c 100644
--- a/chrome/common/extensions/docs/templates/intros/pageAction.html
+++ b/chrome/common/extensions/docs/templates/intros/pageAction.html
@@ -43,9 +43,30 @@ like this:
"name": "My extension",
...
<b>"page_action": {
- "default_icon": "icons/foo.png", <em>// optional</em>
- "default_title": "Do action", <em>// optional; shown in tooltip</em>
- "default_popup": "popup.html" <em>// optional</em>
+ "default_icon": { <em>// optional</em>
+ "19": "images/icon19.png", <em>// optional</em>
+ "38": "images/icon38.png" <em>// optional</em>
+ },
+ "default_title": "Google Mail", <em>// optional; shown in tooltip</em>
+ "default_popup": "popup.html" <em>// optional</em>
+ }</b>,
+ ...
+}</pre>
+
+<p>
+If you only provide one of the 19px or 38px icon size, the extension system will
+scale the icon you provide to the pixel density of the user's display, which
+can lose detail or make it look fuzzy. The old syntax for registering the
+default icon is still supported:
+</p>
+
+<pre>{
+ "name": "My extension",
+ ...
+ <b>"page_action": {
+ ...
+ "default_icon": "images/icon19.png" <em>// optional</em>
+ <em>// equivalent to "default_icon": { "19": "images/icon19.png" }</em>
}</b>,
...
}</pre>
@@ -105,4 +126,4 @@ You can find simple examples of using page actions in the
directory.
For other examples and for help in viewing the source code, see
<a href="samples.html">Samples</a>.
-</p>
+</p>
« no previous file with comments | « chrome/common/extensions/docs/templates/intros/browserAction.html ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698