chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension_icon_factory_delegate.h ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc ('k') | chrome/test/data/extensions/manifest_tests/browser_action_no_default_properties.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

diff --git a/chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json b/chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

new file mode 100644

index 0000000000000000000000000000000000000000..d5bd040e74fc676a594c6b362845460a257530da

--- /dev/null

+++ b/chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

@@ -0,0 +1,13 @@

+ "manifest_version": 2,

+ "name": "my extension",

+ "version": "1.0.0.0",

+ "description": "Browser actin with a default icon set.",

+ "browser_action": {

+ "default_icon": {

+ "19": "",

+ "24": "icon24.png",

+ "38": "icon38.png"

+ }