chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json - Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/manifest_tests/browser_action_invalid_default_icons.json

Issue 10905005: Change browser/page action default icon defined in manifest to support hidpi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review feedback Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/extension_icon_factory_delegate.h ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_scriptbadge_unittest.cc ('k') | chrome/test/data/extensions/manifest_tests/browser_action_no_default_properties.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "manifest_version": 2,

	3 "name": "my extension",

	4 "version": "1.0.0.0",

	5 "description": "Browser actin with a default icon set.",

	6 "browser_action": {

	7 "default_icon": {

	8 "19": "",

	9 "24": "icon24.png",

	10 "38": "icon38.png"

	11 }

	12 }

	13 }

OLD	NEW