Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10900021: Use std::string instead of WTF::String / TextStream (Closed)

Created:
8 years, 3 months ago by jamesr
Modified:
8 years, 3 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Use std::string instead of WTF::String / TextStream BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155792

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -265 lines) Patch
M cc/CCActiveAnimation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCFontAtlas.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/CCFontAtlas.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M cc/CCHeadsUpDisplayLayerImpl.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M cc/CCIOSurfaceLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCIOSurfaceLayerImpl.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/CCLayerImpl.h View 1 2 3 4 5 6 6 chunks +8 lines, -9 lines 0 comments Download
M cc/CCLayerImpl.cpp View 3 chunks +36 lines, -34 lines 0 comments Download
M cc/CCLayerTreeHostImpl.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 1 2 3 4 5 2 chunks +9 lines, -10 lines 0 comments Download
M cc/CCRenderSurface.h View 1 2 3 4 5 6 3 chunks +2 lines, -4 lines 0 comments Download
M cc/CCRenderSurface.cpp View 1 2 3 4 5 3 chunks +24 lines, -20 lines 0 comments Download
M cc/CCRendererGL.cpp View 2 chunks +24 lines, -21 lines 0 comments Download
M cc/CCResourceProvider.cpp View 2 chunks +8 lines, -4 lines 0 comments Download
M cc/CCSchedulerStateMachine.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCSchedulerStateMachine.cpp View 1 2 2 chunks +23 lines, -23 lines 0 comments Download
M cc/CCSchedulerStateMachineTest.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/CCSolidColorLayerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCTextureLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTextureLayerImpl.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M cc/CCTiledLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTiledLayerImpl.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M cc/CCVideoLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCVideoLayerImpl.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/LayerChromium.h View 1 2 3 4 5 3 chunks +3 lines, -5 lines 0 comments Download
M cc/LayerChromium.cpp View 1 2 3 4 5 3 chunks +2 lines, -4 lines 0 comments Download
M cc/ProgramBinding.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/ProgramBinding.cpp View 1 2 3 4 5 6 3 chunks +3 lines, -5 lines 0 comments Download
M cc/RenderSurfaceChromium.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ShaderChromium.h View 16 chunks +26 lines, -26 lines 0 comments Download
M cc/ShaderChromium.cpp View 26 chunks +26 lines, -25 lines 0 comments Download
M cc/TextureCopier.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/TiledLayerChromium.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/cc.gyp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
D cc/stubs/TextStream.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
M webkit/compositor_bindings/WebLayerImpl.cpp View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
enne (OOO)
LGTM https://chromiumcodereview.appspot.com/10900021/diff/10001/cc/CCLayerImpl.h File cc/CCLayerImpl.h (right): https://chromiumcodereview.appspot.com/10900021/diff/10001/cc/CCLayerImpl.h#newcode22 cc/CCLayerImpl.h:22: #include <string> nit: header order https://chromiumcodereview.appspot.com/10900021/diff/10001/cc/ProgramBinding.cpp File cc/ProgramBinding.cpp ...
8 years, 3 months ago (2012-09-10 03:43:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/10900021/14001
8 years, 3 months ago (2012-09-10 15:48:49 UTC) #2
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 19:15:32 UTC) #3 
Change committed as 155792

Powered by Google App Engine
This is Rietveld 408576698