Issue 10898022: mac ninja&make: Expose SDKROOT to the environment.

Issue 10898022: mac ninja&make: Expose SDKROOT to the environment. (Closed)

Created:
8 years, 3 months ago by Nico

Modified:
8 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

mac ninja&make: Expose SDKROOT to the environment. BUG=chromium:131867 Committed: https://code.google.com/p/gyp/source/detail?r=1486

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
M	pylib/gyp/xcode_emulation.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/mac/sdkroot/test.gyp	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/mac/sdkroot/test_shorthand.sh	View	1 2	1 chunk	+2 lines, -0 lines	1 comment	Download
M	test/mac/type_envvars/test_bundle_executable.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_bundle_loadable_module.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_bundle_shared_library.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_nonbundle_executable.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_nonbundle_loadable_module.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_nonbundle_none.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_nonbundle_shared_library.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mac/type_envvars/test_nonbundle_static_library.sh	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

On 2012/08/29 02:45:43, Mark Mentovai wrote: > LGTM > > Quoting thakis: > > “Why ...

8 years, 3 months ago (2012-08-29 02:56:51 UTC) #3

Nico

Now with test (and fixed code). Parts of the test assume a 10.6 sdk, but ...

8 years, 3 months ago (2012-08-29 03:28:47 UTC) #4

Mark Mentovai

8 years, 3 months ago (2012-08-29 12:33:25 UTC) #5

https://chromiumcodereview.appspot.com/10898022/diff/12001/test/mac/sdkroot/t...
File test/mac/sdkroot/test_shorthand.sh (right):

https://chromiumcodereview.appspot.com/10898022/diff/12001/test/mac/sdkroot/t...
test/mac/sdkroot/test_shorthand.sh:8: test $SDKROOT =
/Developer/SDKs/MacOSX10.6.sdk
Quote $SDKROOT OR use [[ instead of test.

Expand Messages | Collapse Messages