Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6658)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback, round 1. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
index f1a706b6a195f3f52d86ccd8ca53ceb8b22bbf16..ba5f651270623bbde099491e4b3a4215ca338db0 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
@@ -119,7 +119,7 @@ bool BrowsingDataExtensionFunction::RunImpl() {
// If we don't have a profile, something's pretty wrong.
DCHECK(profile());
- if (BrowsingDataRemover::is_removing()) {
+ if (BrowsingDataRemover::removing()) {
error_ = extension_browsing_data_api_constants::kOneAtATimeError;
return false;
}
@@ -182,8 +182,8 @@ void BrowsingDataExtensionFunction::StartRemoving() {
// that we're notified after removal) and call remove() with the arguments
// we've generated above. We can use a raw pointer here, as the browsing data
// remover is responsible for deleting itself once data removal is complete.
- BrowsingDataRemover* remover = new BrowsingDataRemover(profile(),
- remove_since_, base::Time::Now());
+ BrowsingDataRemover* remover = BrowsingDataRemover::CreateForRange(profile(),
+ remove_since_, base::Time::Max());
remover->AddObserver(this);
remover->Remove(removal_mask_, origin_set_mask_);
}

Powered by Google App Engine
This is Rietveld 408576698