Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5767)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback, round 1. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index add0506263c805954ad5693abf2c3e8889d8bb51..96bc3922f5af14423368ac47236a3c30f10f1dd5 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1595,9 +1595,8 @@ void ChromeContentBrowserClient::BrowserURLHandlerCreated(
void ChromeContentBrowserClient::ClearCache(RenderViewHost* rvh) {
Profile* profile = Profile::FromBrowserContext(
rvh->GetSiteInstance()->GetProcess()->GetBrowserContext());
- BrowsingDataRemover* remover = new BrowsingDataRemover(profile,
- BrowsingDataRemover::EVERYTHING,
- base::Time::Now());
+ BrowsingDataRemover* remover =
+ BrowsingDataRemover::CreateForUnboundedRange(profile);
remover->Remove(BrowsingDataRemover::REMOVE_CACHE,
BrowsingDataHelper::UNPROTECTED_WEB);
// BrowsingDataRemover takes care of deleting itself when done.
@@ -1606,9 +1605,8 @@ void ChromeContentBrowserClient::ClearCache(RenderViewHost* rvh) {
void ChromeContentBrowserClient::ClearCookies(RenderViewHost* rvh) {
Profile* profile = Profile::FromBrowserContext(
rvh->GetSiteInstance()->GetProcess()->GetBrowserContext());
- BrowsingDataRemover* remover = new BrowsingDataRemover(profile,
- BrowsingDataRemover::EVERYTHING,
- base::Time::Now());
+ BrowsingDataRemover* remover =
+ BrowsingDataRemover::CreateForUnboundedRange(profile);
int remove_mask = BrowsingDataRemover::REMOVE_SITE_DATA;
remover->Remove(remove_mask, BrowsingDataHelper::UNPROTECTED_WEB);
// BrowsingDataRemover takes care of deleting itself when done.

Powered by Google App Engine
This is Rietveld 408576698