Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 10898002: Refactor BrowsingDataRemover creation for clarity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback, round 1. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index fe29a129a91f1966f78ebe723650a64a49af00bf..005f26bf3b6bce39f31e9fb18b80b384db49713f 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -514,11 +514,8 @@ class BrowsingDataRemoverTest : public testing::Test,
int remove_mask,
bool include_protected_origins,
BrowsingDataRemoverTester* tester) {
- BrowsingDataRemover* remover = new BrowsingDataRemover(
- profile_.get(), period,
- // Pick a time that's a bit into the future, since there could be
- // pending writes.
- base::Time::Now() + base::TimeDelta::FromSeconds(10));
+ BrowsingDataRemover* remover = BrowsingDataRemover::CreateForPeriod(
+ profile_.get(), period);
remover->OverrideQuotaManagerForTesting(GetMockManager());
remover->AddObserver(tester);
@@ -536,9 +533,8 @@ class BrowsingDataRemoverTest : public testing::Test,
int remove_mask,
const GURL& remove_origin,
BrowsingDataRemoverTester* tester) {
- BrowsingDataRemover* remover = new BrowsingDataRemover(
- profile_.get(), period,
- base::Time::Now() + base::TimeDelta::FromMilliseconds(10));
+ BrowsingDataRemover* remover = BrowsingDataRemover::CreateForPeriod(
+ profile_.get(), period);
remover->OverrideQuotaManagerForTesting(GetMockManager());
remover->AddObserver(tester);

Powered by Google App Engine
This is Rietveld 408576698