Refactor BrowsingDataRemover creation for clarity.

chrome/browser/browsing_data/browsing_data_remover.h

Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index 5a1e9f879cdc69e42903523f76d99839a1808261..f2424eed4bd536a3cac145e33dff5f4129a6f5e2 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -116,16 +116,18 @@ class BrowsingDataRemover : public content::NotificationObserver,
     virtual ~Observer() {}
   };
 
+  static BrowsingDataRemover* create(Profile* profile,

[markusheintz_, 2012/08/28 10:35:50]

Method names should start with capital letters.
s/create/Create

same below.

+                                     base::Time delete_begin = base::Time(),

[markusheintz_, 2012/08/28 10:35:50]

I think default values for parameters are discouraged in general. Let me double
check that with the style guide.

+                                     base::Time delete_end = base::Time::Max());
+  static BrowsingDataRemover* create(Profile* profile,
+                                     TimePeriod deletionPeriod,
+                                     base::Time delete_end = base::Time::Max());
+
   // Creates a BrowsingDataRemover to remove browser data from the specified
   // profile in the specified time range. Use Remove to initiate the removal.
   BrowsingDataRemover(Profile* profile, base::Time delete_begin,

[markusheintz_, 2012/08/28 10:35:50]

I think you may want to make this constructor private in order to force people
to use the new create methods.

                       base::Time delete_end);
 
-  // Creates a BrowsingDataRemover to remove browser data from the specified
-  // profile in the specified time range.
-  BrowsingDataRemover(Profile* profile, TimePeriod time_period,
-                      base::Time delete_end);
-
   // Removes the specified items related to browsing for all origins that match
   // the provided |origin_set_mask| (see BrowsingDataHelper::OriginSetMask).
   void Remove(int remove_mask, int origin_set_mask);
@@ -287,7 +289,7 @@ class BrowsingDataRemover : public content::NotificationObserver,
   void OnClearedFormData();
 
   // Calculate the begin time for the deletion range specified by |time_period|.
-  base::Time CalculateBeginDeleteTime(TimePeriod time_period);
+  static base::Time CalculateBeginDeleteTime(TimePeriod time_period);

[markusheintz_, 2012/08/28 10:35:50]

After making this static, please order the methods correctly according to this: 
http://code.google.com/p/chromium/issues/detail?id=68682

 
   // Returns true if we're all done.
   bool AllDone();