Refactor BrowsingDataRemover creation for clarity.

chrome/browser/browsing_data/browsing_data_remover.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
 
 #include <set>
 
 #include "base/gtest_prod_util.h"
@@ skipping 98 matching lines @@
   // Observer is notified when the removal is done. Done means keywords have
   // been deleted, cache cleared and all other tasks scheduled.
   class Observer {
    public:
     virtual void OnBrowsingDataRemoverDone() = 0;
 
    protected:
     virtual ~Observer() {}
   };
 
+  static BrowsingDataRemover* create(Profile* profile,

[markusheintz_, 2012/08/28 10:35:50]

Method names should start with capital letters.
s/create/Create

same below.

+                                     base::Time delete_begin = base::Time(),

[markusheintz_, 2012/08/28 10:35:50]

I think default values for parameters are discouraged in general. Let me double
check that with the style guide.

+                                     base::Time delete_end = base::Time::Max());
+  static BrowsingDataRemover* create(Profile* profile,
+                                     TimePeriod deletionPeriod,
+                                     base::Time delete_end = base::Time::Max());
+
   // Creates a BrowsingDataRemover to remove browser data from the specified
   // profile in the specified time range. Use Remove to initiate the removal.
   BrowsingDataRemover(Profile* profile, base::Time delete_begin,

[markusheintz_, 2012/08/28 10:35:50]

I think you may want to make this constructor private in order to force people
to use the new create methods.

                       base::Time delete_end);
 
-  // Creates a BrowsingDataRemover to remove browser data from the specified
-  // profile in the specified time range.
-  BrowsingDataRemover(Profile* profile, TimePeriod time_period,
-                      base::Time delete_end);
-
   // Removes the specified items related to browsing for all origins that match
   // the provided |origin_set_mask| (see BrowsingDataHelper::OriginSetMask).
   void Remove(int remove_mask, int origin_set_mask);
 
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Called when history deletion is done.
   void OnHistoryDeletionDone();
 
@@ skipping 141 matching lines @@
   void OnClearedServerBoundCerts();
 
   // Callback on the DB thread so that we can wait for the form data to be
   // cleared.
   void FormDataDBThreadHop();
 
   // Callback from the above method.
   void OnClearedFormData();
 
   // Calculate the begin time for the deletion range specified by |time_period|.
-  base::Time CalculateBeginDeleteTime(TimePeriod time_period);
+  static base::Time CalculateBeginDeleteTime(TimePeriod time_period);

[markusheintz_, 2012/08/28 10:35:50]

After making this static, please order the methods correctly according to this: 
http://code.google.com/p/chromium/issues/detail?id=68682

 
   // Returns true if we're all done.
   bool AllDone();
 
   // Setter for removing_; DCHECKs that we can only start removing if we're not
   // already removing, and vice-versa.
   static void set_removing(bool removing);
 
   content::NotificationRegistrar registrar_;
 
@@ skipping 65 matching lines @@
 
   ObserverList<Observer> observer_list_;
 
   // Used if we need to clear history.
   CancelableRequestConsumer request_consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_