Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Unified Diff: chrome/renderer/resources/extensions/app_window_custom_bindings.js

Issue 10896032: HTML titlebars for v2 apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: move function call logic into ModuleSystem Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/app_window_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_window_custom_bindings.js b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
index ed430be286df5698911eb2394a619b402ff1515a..68e6a035a8eb9b3e38526ddee7c167f694bc4803 100644
--- a/chrome/renderer/resources/extensions/app_window_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_window_custom_bindings.js
@@ -13,8 +13,14 @@ chromeHidden.registerCustomHook('app.window', function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
apiFunctions.setCustomCallback('create', function(name, request, viewId) {
var view = null;
- if (viewId)
+ if (viewId) {
view = GetView(viewId);
+ if (view) {
+ if (request.args[1].frame != 'none')
+ view._setHasTitlebarInternal(true);
+ delete view._setHasTitlebarInternal;
+ }
+ }
if (request.callback) {
request.callback(view);
delete request.callback;

Powered by Google App Engine
This is Rietveld 408576698