HTML titlebars for v2 apps.

chrome/renderer/extensions/app_window_custom_bindings.cc

Index: chrome/renderer/extensions/app_window_custom_bindings.cc
diff --git a/chrome/renderer/extensions/app_window_custom_bindings.cc b/chrome/renderer/extensions/app_window_custom_bindings.cc
index 5337e8dfb5190656ba9c9047ec52dd063c9b6ea0..70dc133bfe386a8ede60f0bc51e5cc6e83025ee5 100644
--- a/chrome/renderer/extensions/app_window_custom_bindings.cc
+++ b/chrome/renderer/extensions/app_window_custom_bindings.cc
@@ -10,16 +10,17 @@
 #include "chrome/common/extensions/extension_action.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/common/url_constants.h"
+#include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/dispatcher.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "grit/renderer_resources.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLRequest.h"

[Mihai Parparita -not on Chrome, 2012/08/31 23:12:56]

Nit: this seems unused (as does WebNavigationPolicy, WebWindowFeatures,
url_constants.h, and possibly others).

[jeremya, 2012/09/01 01:42:30]

Done.

 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebNavigationPolicy.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebWindowFeatures.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLRequest.h"
 #include "v8/include/v8.h"
 #include "webkit/glue/webkit_glue.h"
 
@@ -28,9 +29,37 @@
 
 namespace extensions {
 
+class DidCreateDocumentElementObserver : public content::RenderViewObserver {
+ public:
+  DidCreateDocumentElementObserver(
+      content::RenderView* view, Dispatcher* dispatcher)
+      : content::RenderViewObserver(view), dispatcher_(dispatcher) {
+  }
+  virtual void DidCreateDocumentElement(WebKit::WebFrame* frame) OVERRIDE {

[Mihai Parparita -not on Chrome, 2012/08/31 23:12:56]

Nit: newline before this.

[jeremya, 2012/09/01 01:42:30]

Done.

+    v8::HandleScope handle_scope;
+    DCHECK(frame);
+    DCHECK(dispatcher_);
+    ChromeV8Context* v8_context =
+        dispatcher_->v8_context_set().GetByV8Context(
+            frame->mainWorldScriptContext());
+
+    if (!v8_context)
+      return;
+    v8::Context::Scope context_scope(v8_context->v8_context());
+    v8_context->module_system()->CallModuleMethod(
+        "injectAppTitlebar", "didCreateDocumentElement");
+  }
+
+ private:
+  Dispatcher* dispatcher_;
+  bool inject_titlebar_;

[Mihai Parparita -not on Chrome, 2012/08/31 23:12:56]

Seems to be unused. Though to be honest, I liked the old way (passing in the
inject_titlebar_ bool in the call here) instead of the new way (which involves
platform_app.js, even though it's otherwise unrelated to the windowing API).

[jeremya, 2012/09/01 01:42:30]

Done. Yeah, I wasn't really sure which was cleaner. I've reverted it to the
passing arguments through C++ way.

+};
+
 AppWindowCustomBindings::AppWindowCustomBindings(Dispatcher* dispatcher)
     : ChromeV8Extension(dispatcher) {
-  RouteStaticFunction("GetView", &GetView);
+  RouteFunction("GetView",
+      base::Bind(&AppWindowCustomBindings::GetView,
+                 base::Unretained(this)));
 }
 
 namespace {
@@ -82,6 +111,8 @@ v8::Handle<v8::Value> AppWindowCustomBindings::GetView(
   if (!view)
     return v8::Undefined();
 
+  new DidCreateDocumentElementObserver(view, dispatcher());
+
   // TODO(jeremya): it doesn't really make sense to set the opener here, but we
   // need to make sure the security origin is set up before returning the DOM
   // reference. A better way to do this would be to have the browser pass the