runtime/vm/exceptions.cc - Issue 10896007: Expose remaining 'errors' in an unified dart:core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 10896007: Expose remaining 'errors' in an unified dart:core. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Make all implementations implement, not extend, the exposed type. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/exceptions.cc

diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc

index 7242b1fb07c561f860fc628b03e0978ffccfe451..e42d463c49f19ec889b570b4ab83a4d11dc5c5bb 100644

--- a/runtime/vm/exceptions.cc

+++ b/runtime/vm/exceptions.cc

@@ -260,11 +260,11 @@ void Exceptions::CreateAndThrowTypeError(intptr_t location,

Instance& type_error = Instance::Handle();

Class& cls = Class::Handle();

if (dst_name.Equals(kCastExceptionDstName)) {

- type_error = NewInstance("CastException");

+ type_error = NewInstance("CastExceptionImplementation");

cls = type_error.clazz();

cls = cls.SuperClass();

} else {

- type_error = NewInstance("TypeError");

+ type_error = NewInstance("TypeErrorImplementation");

cls = type_error.clazz();

}