Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: runtime/lib/error.dart

Issue 10896007: Expose remaining 'errors' in an unified dart:core. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make all implementations implement, not extend, the exposed type. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/error.dart
diff --git a/runtime/lib/error.dart b/runtime/lib/error.dart
index 29a071a670d6e6f2c6fe998972cd3fdf4451a809..2305f378920ce19d4f6f1255274f646cfc2ac5cd 100644
--- a/runtime/lib/error.dart
+++ b/runtime/lib/error.dart
@@ -4,7 +4,7 @@
// Errors are created and thrown by DartVM only.
// Changes here should also be reflected in corelib/error.dart as well
-class AssertionErrorImplementation extends AssertionError {
+class AssertionErrorImplementation implements AssertionError {
factory AssertionErrorImplementation._uninstantiable() {
throw const UnsupportedOperationException(
"AssertionError can only be allocated by the VM");
@@ -21,8 +21,10 @@ class AssertionErrorImplementation extends AssertionError {
final int column;
}
-class TypeError extends AssertionErrorImplementation {
- factory TypeError._uninstantiable() {
+class TypeErrorImplementation
+ extends AssertionErrorImplementation
+ implements TypeError {
+ factory TypeErrorImplementation._uninstantiable() {
throw const UnsupportedOperationException(
"TypeError can only be allocated by the VM");
}
@@ -48,7 +50,9 @@ class TypeError extends AssertionErrorImplementation {
final String malformedError;
}
-class CastException extends TypeError {
+class CastExceptionImplementation
+ extends TypeErrorImplementation
+ implements CastException {
factory CastException._uninstantiable() {
throw const UnsupportedOperationException(
"CastException can only be allocated by the VM");

Powered by Google App Engine
This is Rietveld 408576698