runtime/vm/intermediate_language_test.cc - Issue 10892037: Stop attaching try_index to individual instructions put it at block entry instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_test.cc

Issue 10892037: Stop attaching try_index to individual instructions put it at block entry instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address Srdjan's comment, make meaning of CatchTryIndex clear Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_test.cc

diff --git a/runtime/vm/intermediate_language_test.cc b/runtime/vm/intermediate_language_test.cc

index 13eb7f4cd1077ba2f2a2215191dd8624ac60e5aa..3a9160421b33791f1a175d3e422e22b42501aa36 100644

--- a/runtime/vm/intermediate_language_test.cc

+++ b/runtime/vm/intermediate_language_test.cc

@@ -8,7 +8,8 @@

namespace dart {

TEST_CASE(InstructionTests) {

- TargetEntryInstr* target_instr = new TargetEntryInstr();

+ TargetEntryInstr* target_instr =

+ new TargetEntryInstr(CatchClauseNode::kInvalidTryIndex);

EXPECT(target_instr->IsBlockEntry());

EXPECT(!target_instr->IsBind());

BindInstr* bind_instr =

« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »