Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: runtime/vm/intermediate_language_test.cc

Issue 10892037: Stop attaching try_index to individual instructions put it at block entry instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address Srdjan's comment, make meaning of CatchTryIndex clear Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/intermediate_language.h" 5 #include "vm/intermediate_language.h"
6 #include "vm/unit_test.h" 6 #include "vm/unit_test.h"
7 7
8 namespace dart { 8 namespace dart {
9 9
10 TEST_CASE(InstructionTests) { 10 TEST_CASE(InstructionTests) {
11 TargetEntryInstr* target_instr = new TargetEntryInstr(); 11 TargetEntryInstr* target_instr =
12 new TargetEntryInstr(CatchClauseNode::kInvalidTryIndex);
12 EXPECT(target_instr->IsBlockEntry()); 13 EXPECT(target_instr->IsBlockEntry());
13 EXPECT(!target_instr->IsBind()); 14 EXPECT(!target_instr->IsBind());
14 BindInstr* bind_instr = 15 BindInstr* bind_instr =
15 new BindInstr(BindInstr::kUnused, new CurrentContextComp()); 16 new BindInstr(BindInstr::kUnused, new CurrentContextComp());
16 EXPECT(bind_instr->IsBind()); 17 EXPECT(bind_instr->IsBind());
17 EXPECT(!bind_instr->IsBlockEntry()); 18 EXPECT(!bind_instr->IsBlockEntry());
18 } 19 }
19 20
20 21
21 TEST_CASE(OptimizationTests) { 22 TEST_CASE(OptimizationTests) {
22 Definition* def1 = new PhiInstr(0); 23 Definition* def1 = new PhiInstr(0);
23 Definition* def2 = new PhiInstr(0); 24 Definition* def2 = new PhiInstr(0);
24 UseVal* use1a = new UseVal(def1); 25 UseVal* use1a = new UseVal(def1);
25 UseVal* use1b = new UseVal(def1); 26 UseVal* use1b = new UseVal(def1);
26 EXPECT(use1a->Equals(use1b)); 27 EXPECT(use1a->Equals(use1b));
27 UseVal* use2 = new UseVal(def2); 28 UseVal* use2 = new UseVal(def2);
28 EXPECT(!use2->Equals(use1a)); 29 EXPECT(!use2->Equals(use1a));
29 30
30 ConstantVal* c1 = new ConstantVal(Bool::ZoneHandle(Bool::True())); 31 ConstantVal* c1 = new ConstantVal(Bool::ZoneHandle(Bool::True()));
31 ConstantVal* c2 = new ConstantVal(Bool::ZoneHandle(Bool::True())); 32 ConstantVal* c2 = new ConstantVal(Bool::ZoneHandle(Bool::True()));
32 EXPECT(c1->Equals(c2)); 33 EXPECT(c1->Equals(c2));
33 ConstantVal* c3 = new ConstantVal(Object::ZoneHandle()); 34 ConstantVal* c3 = new ConstantVal(Object::ZoneHandle());
34 ConstantVal* c4 = new ConstantVal(Object::ZoneHandle()); 35 ConstantVal* c4 = new ConstantVal(Object::ZoneHandle());
35 EXPECT(c3->Equals(c4)); 36 EXPECT(c3->Equals(c4));
36 EXPECT(!c3->Equals(c1)); 37 EXPECT(!c3->Equals(c1));
37 } 38 }
38 39
39 } // namespace dart 40 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698