Issue 10892016: Strip out safe-browsing prefix-set checksumming code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10892016: Strip out safe-browsing prefix-set checksumming code. (Closed)

Created:
8 years, 3 months ago by Scott Hess - ex-Googler

Modified:
8 years, 3 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Strip out safe-browsing prefix-set checksumming code. Stripping out the instrumentation in preparation for landing code to transition from bloom filter to prefix set. The histograms indicate that virtually all of the detected problems can be explained by memory corruption, and it's reasonable to assume that the rest are, too (just in a form the tests didn't catch). BUG=71832 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153816

Patch Set 1 #

Patch Set 2 : Merge oops #

Patch Set 3 : Oops, remove unit test for deleted code. #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -421 lines)			Patch
M	chrome/browser/safe_browsing/prefix_set.h	View		2 chunks	+0 lines, -29 lines	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set.cc	View		7 chunks	+2 lines, -108 lines	0 comments	Download
M	chrome/browser/safe_browsing/prefix_set_unittest.cc	View	1 2	1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database.cc	View	1	4 chunks	+1 line, -263 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Per our discussions, this information is no longer worth generating. After this CL, PrefixSet is ...

8 years, 3 months ago (2012-08-28 19:45:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10892016/7001

8 years, 3 months ago (2012-08-28 21:04:39 UTC) #3

Change committed as 153816

Expand Messages | Collapse Messages