Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3045)

Unified Diff: chrome/browser/safe_browsing/prefix_set.h

Issue 10892016: Strip out safe-browsing prefix-set checksumming code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Oops, remove unit test for deleted code. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/prefix_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/prefix_set.h
diff --git a/chrome/browser/safe_browsing/prefix_set.h b/chrome/browser/safe_browsing/prefix_set.h
index f3668f614c9cff17d4da12e336f1c0d18dad25d6..914dd5edb83734009573bbd5cd327ed92cb6db42 100644
--- a/chrome/browser/safe_browsing/prefix_set.h
+++ b/chrome/browser/safe_browsing/prefix_set.h
@@ -73,30 +73,6 @@ class PrefixSet {
// |prefixes|. Prefixes will be added in sorted order.
void GetPrefixes(std::vector<SBPrefix>* prefixes) const;
- // TODO(shess): The following are debugging accessors. Delete once
- // the encoding problem is figured out.
-
- size_t IndexBinFor(size_t target_index) const;
-
- // The number of prefixes represented.
- size_t GetSize() const;
-
- // Returns |true| if the element at |target_index| is between items in the
- // |index_| array.
- bool IsDeltaAt(size_t target_index) const;
-
- // Returns the delta used to calculate the element at
- // |target_index|. Only call if |IsDeltaAt()| returned |true|.
- uint16 DeltaAt(size_t target_index) const;
-
- // Check whether |index_| and |deltas_| still match the checksum
- // generated during construction.
- bool CheckChecksum() const;
-
- // Accumulates xor checksum over what GetPrefixes() would return,
- // without requiring a large temporary structure.
- SBPrefix GetPrefixesChecksum() const;
-
private:
// Maximum number of consecutive deltas to encode before generating
// a new index entry. This helps keep the worst-case performance
@@ -119,11 +95,6 @@ class PrefixSet {
// |index_|, or the end of |deltas_| for the last |index_| pair.
std::vector<uint16> deltas_;
- // For debugging, used to verify that |index_| and |deltas| were not
- // changed after generation during construction. |checksum_| is
- // calculated from the data used to construct those vectors.
- uint32 checksum_;
-
DISALLOW_COPY_AND_ASSIGN(PrefixSet);
};
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/prefix_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698