Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 10891044: RestoreTabHelper > SessionTabHelper, move more session stuff into it. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
Reviewers:
gone, sky
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, Aaron Boodman, tfarina, ajwong+watch_chromium.org, kkania, marja+watch_chromium.org, robertshield, brettw-cc_chromium.org
Visibility:
Public.

Description

RestoreTabHelper > SessionTabHelper, move more session stuff into it. BUG=107201 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154186 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -126 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_as_browser_action_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_id_map.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_id.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 11 chunks +24 lines, -24 lines 0 comments Download
A + chrome/browser/sessions/session_tab_helper.h View 4 chunks +8 lines, -7 lines 0 comments Download
A + chrome/browser/sessions/session_tab_helper.cc View 3 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 5 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
sky: You're an owner, and while this is just a rename and a little code ...
8 years, 3 months ago (2012-08-29 22:03:08 UTC) #1
gone
On 2012/08/29 22:03:08, Avi wrote: > sky: You're an owner, and while this is just ...
8 years, 3 months ago (2012-08-29 22:08:12 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 3 months ago (2012-08-29 22:38:10 UTC) #3
sky
LGTM
8 years, 3 months ago (2012-08-30 00:04:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891044/1
8 years, 3 months ago (2012-08-30 03:55:42 UTC) #5
commit-bot: I haz the power
Try job failure for 10891044-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-08-30 05:15:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10891044/1
8 years, 3 months ago (2012-08-30 14:25:12 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-08-30 17:28:59 UTC) #8
Change committed as 154186

Powered by Google App Engine
This is Rietveld 408576698