Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10890027: Fix errors in xvfb.py and run_test_from_archive.py (Closed)

Created:
8 years, 3 months ago by M-A Ruel
Modified:
8 years, 3 months ago
Reviewers:
cmp, csharp
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Fix errors in xvfb.py and run_test_from_archive.py run_test_from_archive_smoke_test.py didn't test directory creation so this was broken. I tested it manually and weeded out the current bug. For the modification in test_env.py, this is concerning. Without this modification, I was getting: Traceback (most recent call last): File "../testing/xvfb.py", line 133, in <module> sys.exit(main()) File "../testing/xvfb.py", line 129, in main return run_executable(sys.argv[2:], sys.argv[1], os.environ.copy()) File "../testing/xvfb.py", line 118, in run_executable return test_env.run_executable(cmd, env) AttributeError: 'module' object has no attribute 'run_executable' Adding a print() or anything else fixed the problem. I'm not sure what's corrupted on my system. TBR=cmp@chromium.org,csharp@chromium.org NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M testing/test_env.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/isolate/run_test_from_archive.py View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10890027/1
8 years, 3 months ago (2012-08-29 03:50:52 UTC) #1
commit-bot: I haz the power
Change committed as 153847
8 years, 3 months ago (2012-08-29 03:51:23 UTC) #2
M-A Ruel
Also reduced logging.
8 years, 3 months ago (2012-08-29 03:52:11 UTC) #3
csharp
lgtm
8 years, 3 months ago (2012-08-29 13:33:17 UTC) #4
cmp
8 years, 3 months ago (2012-08-29 21:05:55 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698