Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: tools/isolate/run_test_from_archive.py

Issue 10890027: Fix errors in xvfb.py and run_test_from_archive.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/test_env.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/run_test_from_archive.py
diff --git a/tools/isolate/run_test_from_archive.py b/tools/isolate/run_test_from_archive.py
index ad78617608da9cf9c94885be2d086120b8fe6cb6..25b385bef06cf1634e5f9438e2c94490749e0cfd 100755
--- a/tools/isolate/run_test_from_archive.py
+++ b/tools/isolate/run_test_from_archive.py
@@ -654,7 +654,7 @@ class Manifest(object):
assert self.can_fetch
if not self._manifest_parsed or self.files_fetched:
return
- logging.info('fetch_files(%s)' % self.obj_hash)
+ logging.debug('fetch_files(%s)' % self.obj_hash)
for filepath, properties in self.data.get('files', {}).iteritems():
# Root manifest has priority on the files being mapped. In particular,
# overriden files must not be fetched.
@@ -662,7 +662,7 @@ class Manifest(object):
files[filepath] = properties
if 'sha-1' in properties:
# Preemptively request files.
- logging.info('fetching %s' % filepath)
+ logging.debug('fetching %s' % filepath)
cache.retrieve(Remote.MED, properties['sha-1'])
self.files_fetched = True
@@ -778,8 +778,10 @@ def run_tha_test(manifest_hash, cache_dir, remote, policies):
logging.debug('Creating directories')
# Creates the tree of directories to create.
directories = set(os.path.dirname(f) for f in settings.files)
- for item in directories:
- directories.add(os.path.dirname(item))
+ for item in list(directories):
+ while item:
+ directories.add(item)
+ item = os.path.dirname(item)
for d in sorted(directories):
if d:
os.mkdir(os.path.join(outdir, d))
« no previous file with comments | « testing/test_env.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698