Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2438)

Unified Diff: content/renderer/v8_value_converter_impl.h

Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ignore -> omit Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/v8_value_converter_impl.h
diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h
index baf061ab0c47b08b627cfb2e180ff85cb6991eeb..cde780a2147656e99ae61763818d2f02f2c16de0 100644
--- a/content/renderer/v8_value_converter_impl.h
+++ b/content/renderer/v8_value_converter_impl.h
@@ -23,8 +23,8 @@ class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter {
V8ValueConverterImpl();
// V8ValueConverter implementation.
- virtual bool GetUndefinedAllowed() const OVERRIDE;
- virtual void SetUndefinedAllowed(bool val) OVERRIDE;
+ virtual UndefinedValueBehavior GetUndefinedValueBehavior() const OVERRIDE;
+ virtual void SetUndefinedValueBehavior(UndefinedValueBehavior val) OVERRIDE;
virtual bool GetDateAllowed() const OVERRIDE;
virtual void SetDateAllowed(bool val) OVERRIDE;
virtual bool GetRegexpAllowed() const OVERRIDE;
@@ -58,8 +58,8 @@ class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter {
base::Value* FromV8Object(v8::Handle<v8::Object> object,
std::set<int>* unique_set) const;
- // If true, we will convert undefined JavaScript values to null.
- bool undefined_allowed_;
+ // Determines how undefined values should be converted.
+ UndefinedValueBehavior undefined_value_behavior_;
// If true, we will convert Date JavaScript objects to doubles.
bool date_allowed_;

Powered by Google App Engine
This is Rietveld 408576698