content/renderer/render_view_impl.cc - Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 10890002: Make V8ValueConverter.FromV8Value behave similarly to JSON.stringify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ignore -> omit Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index d2d7de38ccf50dff6bf95412943386515cebe84b..002c858e52a9080568acf9b8b92cb6ec591bb81d 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -4254,7 +4254,9 @@ void RenderViewImpl::EvaluateScript(const string16& frame_xpath,

V8ValueConverterImpl converter;

converter.SetDateAllowed(true);

converter.SetRegexpAllowed(true);

- list.Set(0, converter.FromV8Value(result, context));

+ base::Value* result_value = converter.FromV8Value(result, context);

+ list.Set(0, result_value ? result_value :

+ base::Value::CreateNullValue());

} else {

list.Set(0, Value::CreateNullValue());

}