Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10885049: Extensions Docs Server: KILL BUILD.PY (Closed)

Created:
8 years, 3 months ago by cduvall
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Extensions Docs Server: KILL BUILD.PY build.py is dead. This removes build.py, the old server, and presubmit checks about the old docs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154049

Patch Set 1 #

Total comments: 8

Patch Set 2 : kill PRESUBMIT #

Total comments: 6

Patch Set 3 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -943 lines) Patch
D chrome/common/extensions/PRESUBMIT.py View 1 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/common/extensions/PRESUBMIT_test.py View 1 1 chunk +0 lines, -461 lines 0 comments Download
M chrome/common/extensions/docs/build/build.py View 1 1 chunk +4 lines, -250 lines 0 comments Download
M chrome/common/extensions/docs/server2/README View 1 2 2 chunks +23 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cduvall
8 years, 3 months ago (2012-08-30 01:40:33 UTC) #1
Aaron Boodman
per kalman's point in irc, we shouldn't delete server, right? https://chromiumcodereview.appspot.com/10885049/diff/1/chrome/common/extensions/docs/build/build.py File chrome/common/extensions/docs/build/build.py (right): https://chromiumcodereview.appspot.com/10885049/diff/1/chrome/common/extensions/docs/build/build.py#newcode9 ...
8 years, 3 months ago (2012-08-30 01:47:00 UTC) #2
Aaron Boodman
Pre-emptive lgtm if server is undeleted.
8 years, 3 months ago (2012-08-30 01:47:28 UTC) #3
not at google - send to devlin
is deleting server a problem? it's only deleting the content that server relies on that ...
8 years, 3 months ago (2012-08-30 01:49:42 UTC) #4
cduvall
https://chromiumcodereview.appspot.com/10885049/diff/1/chrome/common/extensions/PRESUBMIT.py File chrome/common/extensions/PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/10885049/diff/1/chrome/common/extensions/PRESUBMIT.py#newcode102 chrome/common/extensions/PRESUBMIT.py:102: def StaticDocBuilt(static_file, input_api): On 2012/08/30 01:49:42, kalman wrote: > ...
8 years, 3 months ago (2012-08-30 02:09:08 UTC) #5
not at google - send to devlin
https://chromiumcodereview.appspot.com/10885049/diff/8001/chrome/common/extensions/docs/server2/README File chrome/common/extensions/docs/server2/README (right): https://chromiumcodereview.appspot.com/10885049/diff/8001/chrome/common/extensions/docs/server2/README#newcode42 chrome/common/extensions/docs/server2/README:42: - Otherwise, they will mostly be in chrome/common/extensions/api/ or ...
8 years, 3 months ago (2012-08-30 02:12:08 UTC) #6
cduvall
https://chromiumcodereview.appspot.com/10885049/diff/8001/chrome/common/extensions/docs/server2/README File chrome/common/extensions/docs/server2/README (right): https://chromiumcodereview.appspot.com/10885049/diff/8001/chrome/common/extensions/docs/server2/README#newcode42 chrome/common/extensions/docs/server2/README:42: - Otherwise, they will mostly be in chrome/common/extensions/api/ or ...
8 years, 3 months ago (2012-08-30 02:19:11 UTC) #7
not at google - send to devlin
8 years, 3 months ago (2012-08-30 02:22:02 UTC) #8
lgtm

Powered by Google App Engine
This is Rietveld 408576698