Extensions Docs Server: KILL BUILD.PY

chrome/common/extensions/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os.path  # for initializing constants
 
 # Directories that we run presubmit checks on.
 PRESUBMIT_PATH = os.path.normpath('chrome/common/extensions/PRESUBMIT.py')
 API_DIR = os.path.normpath('chrome/common/extensions/api')
 DOC_DIR = os.path.normpath('chrome/common/extensions/docs')
@@ skipping 14 matching lines @@
     'This change modifies the extension docs but the generated docs have '
     'not been updated properly. See %s for more info.' % README)
 BUILD_SCRIPT = os.path.join(BUILD_DIR, 'build.py')
 REBUILD_INSTRUCTIONS = (
     'First build DumpRenderTree, then update the docs by running:\n  %s'
     ' --page-name=<apiName>' %
     BUILD_SCRIPT)
 
 
 def CheckChangeOnUpload(input_api, output_api):
-  return (CheckPresubmitChanges(input_api, output_api) +
-          CheckDocChanges(input_api, output_api))
+  return CheckPresubmitChanges(input_api, output_api)
 
 def CheckChangeOnCommit(input_api, output_api):
-  return (CheckPresubmitChanges(input_api, output_api) +
-          CheckDocChanges(input_api, output_api, strict=False))
+  return CheckPresubmitChanges(input_api, output_api)
 
 def CheckPresubmitChanges(input_api, output_api):
   for PRESUBMIT_PATH in input_api.LocalPaths():
     return input_api.canned_checks.RunUnitTests(input_api, output_api,
                                                 ['./PRESUBMIT_test.py'])
   return []
 
-def CheckDocChanges(input_api, output_api, strict=True):
-  warnings = []
-
-  for af in input_api.AffectedFiles():
-    path = af.LocalPath()
-    if IsSkippedFile(path, input_api):
-      continue
-
-    elif (IsApiFile(path, input_api) or
-          IsBuildFile(path, input_api) or
-          IsTemplateFile(path, input_api) or
-          IsJsFile(path, input_api) or
-          IsCssFile(path, input_api)):
-      # These files do not always cause changes to the generated docs
-      # so we can ignore them if not running strict checks.
-      if strict and not DocsGenerated(input_api):
-        warnings.append('Docs out of sync with %s changes.' % path)
-
-    elif IsStaticDoc(path, input_api):
-      if not StaticDocBuilt(af, input_api):
-        warnings.append('Changes to %s not reflected in generated doc.' % path)
-
-    elif IsSampleFile(path, input_api):
-      if not SampleZipped(af, input_api):
-        warnings.append('Changes to sample %s have not been re-zipped.' % path)
-
-    elif IsGeneratedDoc(path, input_api):
-      if not NonGeneratedFilesEdited(input_api):
-        warnings.append('Changes to generated doc %s not reflected in '
-                        'non-generated files.' % path)
-
-  if warnings:
-    warnings.sort()
-    warnings = [' - %s\n' % w for w in warnings]
-    # Prompt user if they want to continue.
-    return [output_api.PresubmitPromptWarning(REBUILD_WARNING + '\n' +
-                                              ''.join(warnings) +
-                                              REBUILD_INSTRUCTIONS)]
-  return []
-
 def IsSkippedFile(path, input_api):
   return input_api.os_path.basename(path) in EXCEPTIONS
 
 def IsApiFile(path, input_api):
   return (input_api.os_path.dirname(path) == API_DIR and
           (path.endswith('.json') or path.endswith('.idl')))
 
 def IsBuildFile(path, input_api):
   return input_api.os_path.dirname(path) == BUILD_DIR
 
@@ skipping 36 matching lines @@
   """
   return any(IsApiFile(path, input_api) or
              IsBuildFile(path, input_api) or
              IsTemplateFile(path, input_api) or
              IsJsFile(path, input_api) or
              IsCssFile(path, input_api) or
              IsStaticDoc(path, input_api) or
              IsSampleFile(path, input_api)
              for path in input_api.LocalPaths())
 
 def StaticDocBuilt(static_file, input_api):

[not at google - send to devlin, 2012/08/30 01:49:42]

can delete this

[cduvall, 2012/08/30 02:09:08]

Done.

   """Return True if the generated doc that corresponds to the |static_file|
   is also in this change. Both files must also contain matching changes.
   """
   for subdir in [APPS_DIR, EXTENSIONS_DIR]:
     generated_file = _FindFileInAlternateDir(static_file, subdir, input_api)
     if _ChangesMatch(generated_file, static_file):
       return True
   return False
 
 def _FindFileInAlternateDir(affected_file, alt_dir, input_api):
@@ skipping 55 matching lines @@
         found  = True
       else:
         next_generated += 1
         start_pos = 0
 
     if not found:
       return False
 
   return True
 
 def SampleZipped(sample_file, input_api):

[not at google - send to devlin, 2012/08/30 01:49:42]

can delete this

actually basically everythign in this file you can delete except the unit test
running

[cduvall, 2012/08/30 02:09:08]

It is gone.

   """Return True if the zipfile that should contain |sample_file| is in
   this change.
   """
   sample_path = sample_file.LocalPath()
   for af in input_api.AffectedFiles():
     root, ext = input_api.os_path.splitext(af.LocalPath())
     if ext == '.zip' and sample_path.startswith(root):
       return True
   return False