Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: runtime/vm/stub_code_x64_test.cc

Issue 10885039: Deoptimization can occur at Dart calls (includes native calls to C) but not at runtime calls. This … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/native_entry.h ('K') | « runtime/vm/stub_code_ia32_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64_test.cc
===================================================================
--- runtime/vm/stub_code_x64_test.cc (revision 11533)
+++ runtime/vm/stub_code_x64_test.cc (working copy)
@@ -112,55 +112,6 @@
EXPECT_EQ((value1 + value2), result.Value());
}
-
-// Test calls to stub code which calls a native C function.
-static void GenerateCallToCallNativeCFunctionStub(Assembler* assembler,
- int value1, int value2) {
- const int argc = 2;
- const Smi& smi1 = Smi::ZoneHandle(Smi::New(value1));
- const Smi& smi2 = Smi::ZoneHandle(Smi::New(value2));
- const Object& result = Object::ZoneHandle();
- const String& native_name = String::ZoneHandle(String::New("TestSmiSub"));
- Dart_NativeFunction native_function =
- NativeTestEntry_Lookup(native_name, argc);
- ASSERT(native_function != NULL);
- const Context& context = Context::ZoneHandle(Context::New(0, Heap::kOld));
- ASSERT(context.isolate() == Isolate::Current());
- __ enter(Immediate(0));
- __ LoadObject(CTX, context);
- __ PushObject(smi1); // Push argument 1 smi1.
- __ PushObject(smi2); // Push argument 2 smi2.
- __ PushObject(result); // Push Null object for return value.
- // Pass a pointer to the first argument in RAX.
- __ leaq(RAX, Address(RSP, 2 * kWordSize));
- __ movq(RBX, Immediate(reinterpret_cast<uword>(native_function)));
- __ movq(R10, Immediate(argc));
- __ call(&StubCode::CallNativeCFunctionLabel());
- __ popq(RAX); // Pop return value from return slot.
- __ AddImmediate(RSP, Immediate(argc * kWordSize));
- __ leave();
- __ ret();
-}
-
-
-TEST_CASE(CallNativeCFunctionStubCode) {
- extern const Function& RegisterFakeFunction(const char* name,
- const Code& code);
- const int value1 = 15;
- const int value2 = 20;
- const char* kName = "Test_CallNativeCFunctionStubCode";
- Assembler _assembler_;
- GenerateCallToCallNativeCFunctionStub(&_assembler_, value1, value2);
- const Code& code = Code::Handle(Code::FinalizeCode(
- *CreateFunction(kName), &_assembler_));
- const Function& function = RegisterFakeFunction(kName, code);
- GrowableArray<const Object*> arguments;
- const Array& kNoArgumentNames = Array::Handle();
- Smi& result = Smi::Handle();
- result ^= DartEntry::InvokeStatic(function, arguments, kNoArgumentNames);
- EXPECT_EQ((value1 - value2), result.Value());
-}
-
} // namespace dart
#endif // defined TARGET_ARCH_X64
« runtime/vm/native_entry.h ('K') | « runtime/vm/stub_code_ia32_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698