Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: runtime/vm/native_entry.h

Issue 10885039: Deoptimization can occur at Dart calls (includes native calls to C) but not at runtime calls. This … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/native_entry.h
===================================================================
--- runtime/vm/native_entry.h (revision 11533)
+++ runtime/vm/native_entry.h (working copy)
@@ -15,6 +15,7 @@
namespace dart {
+DECLARE_FLAG(bool, deoptimize_alot);
DECLARE_FLAG(bool, trace_natives);
// Forward declarations.
@@ -33,6 +34,7 @@
#define DEFINE_NATIVE_ENTRY(name, argument_count) \
+ extern void DeoptimizeAll(); \
siva 2012/08/30 01:37:30 why not include "code_generator.h" in this file in
srdjan 2012/08/30 17:16:16 Done.
static void DN_Helper##name(Isolate* isolate, NativeArguments* arguments); \
void NATIVE_ENTRY_FUNCTION(name)(Dart_NativeArguments args) { \
CHECK_STACK_ALIGNMENT; \
@@ -44,6 +46,7 @@
Zone zone(arguments->isolate()); \
HANDLESCOPE(arguments->isolate()); \
DN_Helper##name(arguments->isolate(), arguments); \
+ if (FLAG_deoptimize_alot) DeoptimizeAll(); \
} \
VERIFY_ON_TRANSITION; \
} \

Powered by Google App Engine
This is Rietveld 408576698