Fix for failing unit tests PasswordStoreDefaultTest.*

Fix for failing unit tests PasswordStoreDefaultTest.*

There seems to a bug in STLport for Android because of which
copying a vector into a set using
expectations(first.begin(), first.end()) causes a crash.
If we instead use
std::copy(first.begin(), first.end(), std::inserter(expectations,
    expectations.begin()));
there is no crash.


BUG=144161
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154214

[Ilya Sherman, 2012-08-29 22:53:51]

LGTM with nit

https://chromiumcodereview.appspot.com/10885019/diff/2001/chrome/browser/pass...
File chrome/browser/password_manager/password_form_data.cc (right):

https://chromiumcodereview.appspot.com/10885019/diff/2001/chrome/browser/pass...
chrome/browser/password_manager/password_form_data.cc:81:
expectations.begin()));
nit: Please add a comment documenting why this is written in this more complex
way.

[Ramya, 2012-08-29 23:01:33]

PTAL

http://codereview.chromium.org/10885019/diff/2001/chrome/browser/password_man...
File chrome/browser/password_manager/password_form_data.cc (right):

http://codereview.chromium.org/10885019/diff/2001/chrome/browser/password_man...
chrome/browser/password_manager/password_form_data.cc:81:
expectations.begin()));
On 2012/08/29 22:53:51, Ilya Sherman wrote:
> nit: Please add a comment documenting why this is written in this more complex
> way.

Done.

[Ilya Sherman, 2012-08-29 23:12:36]

LGTM, thanks :)

[Yaron, 2012-08-29 23:16:34]

lgtm

[commit-bot: I haz the power, 2012-08-30 16:37:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cramya@chromium.org/10885019/5001

[commit-bot: I haz the power, 2012-08-30 18:42:10]

Change committed as 154214