Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: chrome/browser/password_manager/password_form_data.cc

Issue 10885019: Fix for failing unit tests PasswordStoreDefaultTest.* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding comment to explain the change Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gtest_filter/unit_tests_disabled ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_form_data.cc
diff --git a/chrome/browser/password_manager/password_form_data.cc b/chrome/browser/password_manager/password_form_data.cc
index b919770efc1f8d166beb72e9e6cc5b9f85ee2008..3c6f377224c6c944db4203770ad83ce5286de776 100644
--- a/chrome/browser/password_manager/password_form_data.cc
+++ b/chrome/browser/password_manager/password_form_data.cc
@@ -76,7 +76,14 @@ bool ContainsSamePasswordFormsPtr(
const std::vector<PasswordForm*>& second) {
if (first.size() != second.size())
return false;
- SetOfForms expectations(first.begin(), first.end());
+
+ // TODO(cramya): As per b/7079906, the STLport of Android causes a crash
+ // if we use expectations(first.begin(), first.end()) to copy a vector
+ // into a set rather than std::copy that is used below.
+ // Need to revert this once STLport is fixed.
+ SetOfForms expectations;
+ std::copy(first.begin(), first.end(), std::inserter(expectations,
+ expectations.begin()));
for (unsigned int i = 0; i < second.size(); ++i) {
const PasswordForm* actual = second[i];
bool found_match = false;
« no previous file with comments | « build/android/gtest_filter/unit_tests_disabled ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698