Added restore functionality for maximize full/left/right

Added restore functionality for maximize full/left/right


BUG=141725
TEST=unit test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154226

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154295

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154372

[Mr4D (OOO till 08-26), 2012-08-27 21:14:24]

Sky,

as discussed, here is the restore (maximize/left/right) functionality.

Please have a look!

[sky, 2012-08-27 22:18:16]

Also, I don't think this addresses 141750.

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash.cc
File ash/wm/custom_frame_view_ash.cc (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash.c...
ash/wm/custom_frame_view_ash.cc:151: maximize_button_->ToggleMaximize();
ToggleMaximized

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash_u...
File ash/wm/custom_frame_view_ash_unittest.cc (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:487: void
ClickMaxButton(ash::FrameMaximizeButton* maximize_button,
Wrap maximize_button to next line so that it lines up with other params. Also,
add a description.

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:526: RunAllPendingInMessageLoop();
Why do you need to explicitly run the message loop here? At a minimum at a
comment.

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
ash/wm/workspace/frame_maximize_button.cc:550: DCHECK(!bounds.y());
Why does the x/y need to be 0 here? Might it differ in multi-mon?

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
File ash/wm/workspace/frame_maximize_button.h (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
ash/wm/workspace/frame_maximize_button.h:69: void ToggleMaximize();
ToggleMaximized

http://codereview.chromium.org/10883069/diff/1/chrome/browser/ui/views/ash/br...
File chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc (right):

http://codereview.chromium.org/10883069/diff/1/chrome/browser/ui/views/ash/br...
chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc:375:
maximize_button_->ToggleMaximize();
This shouldn't call through to the maximize button. It should merge with the
code in WorkspaceEventFilter ToggleMaximizedState.

[Mr4D (OOO till 08-26), 2012-08-28 01:30:25]

Addressed.

Sorry that there is no describing patch name, but remote linux has a SERIOUS
problem with keyboards.

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash.cc
File ash/wm/custom_frame_view_ash.cc (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash.c...
ash/wm/custom_frame_view_ash.cc:151: maximize_button_->ToggleMaximize();
On 2012/08/27 22:18:16, sky wrote:
> ToggleMaximized

Done.

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash_u...
File ash/wm/custom_frame_view_ash_unittest.cc (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:487: void
ClickMaxButton(ash::FrameMaximizeButton* maximize_button,
On 2012/08/27 22:18:16, sky wrote:
> Wrap maximize_button to next line so that it lines up with other params. Also,
> add a description.

Done.

http://codereview.chromium.org/10883069/diff/1/ash/wm/custom_frame_view_ash_u...
ash/wm/custom_frame_view_ash_unittest.cc:526: RunAllPendingInMessageLoop();
I have seen that other tests were doing this, so I was adding it as well.
Removed. Done.

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
ash/wm/workspace/frame_maximize_button.cc:550: DCHECK(!bounds.y());
Very good point! Changed!

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
File ash/wm/workspace/frame_maximize_button.h (right):

http://codereview.chromium.org/10883069/diff/1/ash/wm/workspace/frame_maximiz...
ash/wm/workspace/frame_maximize_button.h:69: void ToggleMaximize();
On 2012/08/27 22:18:16, sky wrote:
> ToggleMaximized

Done.

http://codereview.chromium.org/10883069/diff/1/chrome/browser/ui/views/ash/br...
File chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc (right):

http://codereview.chromium.org/10883069/diff/1/chrome/browser/ui/views/ash/br...
chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc:375:
maximize_button_->ToggleMaximize();
On 2012/08/27 22:18:16, sky wrote:
> This shouldn't call through to the maximize button. It should merge with the
> code in WorkspaceEventFilter ToggleMaximizedState.

Done.

[sky, 2012-08-28 15:38:36]

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:498: // Get the window coordinates on
the screen for restore purposes.
spacing is off here.

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_event_filter.cc (right):

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_event_filter.cc:45: // The only way this can happen
is that we are in left/right maximized
I don't understand this if. If there are restore bounds, we should use them and
not maximize. Won't this code change break the double click in resize area to
single axis maximize/single axis restore? What am I missing?

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_event_filter.h (right):

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_event_filter.h:19: ASH_EXPORT void
ToggleMaximizedState(aura::Window* window);
Move this to window_util.

http://codereview.chromium.org/10883069/diff/10001/ui/views/widget/native_wid...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/10883069/diff/10001/ui/views/widget/native_wid...
ui/views/widget/native_widget_aura.cc:591: // stored, we might are on Left/Right
maximize mode and only need to restore
Remember there is more than just left/right maximize mode that triggers there to
be restore bounds.

[Mr4D (OOO till 08-26), 2012-08-28 19:40:53]

See comments.

Again - remote linux took 2 enter's for one and the patch has no name. Sorry for
that.

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:498: // Get the window coordinates on
the screen for restore purposes.
Done. But here is a question: This whole paragraph is enclosed by a bracket
section. Shouldn't it be indented therefore 2 more spaces?

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/workspace...
File ash/wm/workspace/workspace_event_filter.h (right):

http://codereview.chromium.org/10883069/diff/10001/ash/wm/workspace/workspace...
ash/wm/workspace/workspace_event_filter.h:19: ASH_EXPORT void
ToggleMaximizedState(aura::Window* window);
On 2012/08/28 15:38:36, sky wrote:
> Move this to window_util.

Done.

http://codereview.chromium.org/10883069/diff/10001/ui/views/widget/native_wid...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/10883069/diff/10001/ui/views/widget/native_wid...
ui/views/widget/native_widget_aura.cc:591: // stored, we might are on Left/Right
maximize mode and only need to restore
I asked before starting this CL if it could be that we ever have a restore
bounds set and we are not minimized / maximized / fullscreen - and you said no.
So I assumed that having a restore bounds and being in a normal mode already
must mean that we are in the 'pseudo' maximize mode. Am I wrong?

[sky, 2012-08-28 20:46:36]

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.cc
File ash/wm/window_util.cc (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.cc#newc...
ash/wm/window_util.cc:141: window->SetProperty(aura::client::kShowStateKey,
Don't maximize here, just set the bounds.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.h
File ash/wm/window_util.h (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.h#newco...
ash/wm/window_util.h:75: // The |window| will be toggled between full screen and
normal mode. It will
full screen -> maximized

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:516:
ash::wm::ToggleMaximizedState(widget->GetNativeWindow());
Why is this toggling? This should explicitly maximize.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:538: gfx::Rect bounds =
frame_->GetWidget()->GetNativeWindow()->bounds();
frame_->GetWidget()->GetWindowBoundsInScreen().

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:538: gfx::Rect bounds =
frame_->GetWidget()->GetNativeWindow()->bounds();
Remember that you can get here if you double clicked the frame border to
maximize it along an axis. You need more checks to ensure it's really snapped.
Maybe as long as the width >= the min snap size?

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/maximize_...
File ash/wm/workspace/maximize_types.h (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/maximize_...
ash/wm/workspace/maximize_types.h:11: enum MaximizeType {
These types are specific to FrameMaximizeBubble and naming them maximize is a
bit misleading. How about MaximizeBubbleFrameState: FRAME_STATE_NONE,
FRAME_STATE_MAXIMIZED, FRAME_STATE_SNAPPED_LEFT, FRAME_STATE_SNAPPED_RIGHT. The
MaximizeBubble in the front is a bit wordy, but that's just to reinforce these
starts are just for FrameMaximizeFoo.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/maximize_...
ash/wm/workspace/maximize_types.h:21: 
Remove empty lines.

[Mr4D (OOO till 08-26), 2012-08-28 22:40:02]

Hello sky!

I was doing - most of what you requested. The other comments were (I think)
discussed and identified good as is. I discussed with Alex the behavior and he
wanted the maximize button behavior as implemented. So - yes this is what he
wants.

Please have another look!

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.cc
File ash/wm/window_util.cc (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.cc#newc...
ash/wm/window_util.cc:141: window->SetProperty(aura::client::kShowStateKey,
No - that would not work. The left/right snapped mode is already active, and we
*want* to go into the maximized mode. Unless you want me to change the behavior
from maximized into restore. (which was our discussion). Please let me know!

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.h
File ash/wm/window_util.h (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/window_util.h#newco...
ash/wm/window_util.h:75: // The |window| will be toggled between full screen and
normal mode. It will
On 2012/08/28 20:46:36, sky wrote:
> full screen -> maximized

Done.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:516:
ash::wm::ToggleMaximizedState(widget->GetNativeWindow());
On 2012/08/28 20:46:36, sky wrote:
> Why is this toggling? This should explicitly maximize.

Done.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:538: gfx::Rect bounds =
frame_->GetWidget()->GetNativeWindow()->bounds();
On 2012/08/28 20:46:36, sky wrote:
> frame_->GetWidget()->GetWindowBoundsInScreen().

Done.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:538: gfx::Rect bounds =
frame_->GetWidget()->GetNativeWindow()->bounds();
HHHmm. Does that case also have restore coordinates set?

Okay, I added that.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/maximize_...
File ash/wm/workspace/maximize_types.h (right):

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/maximize_...
ash/wm/workspace/maximize_types.h:11: enum MaximizeType {
On 2012/08/28 20:46:36, sky wrote:
> These types are specific to FrameMaximizeBubble and naming them maximize is a
> bit misleading. How about MaximizeBubbleFrameState: FRAME_STATE_NONE,
> FRAME_STATE_MAXIMIZED, FRAME_STATE_SNAPPED_LEFT, FRAME_STATE_SNAPPED_RIGHT.
The
> MaximizeBubble in the front is a bit wordy, but that's just to reinforce these
> starts are just for FrameMaximizeFoo.

Done.

http://codereview.chromium.org/10883069/diff/16001/ash/wm/workspace/maximize_...
ash/wm/workspace/maximize_types.h:21: 
On 2012/08/28 20:46:36, sky wrote:
> Remove empty lines.

Done.

[Mr4D (OOO till 08-26), 2012-08-29 16:26:09]

Sky,

addressed as discussed. Well - I hope so :)

Please have another look!

[sky, 2012-08-29 17:29:20]

http://codereview.chromium.org/10883069/diff/14002/ash/wm/base_layout_manager.cc
File ash/wm/base_layout_manager.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/base_layout_manager...
ash/wm/base_layout_manager.cc:140: GetRestoreBoundsInParent(window).IsEmpty() &&
Use GetRestoreBoundsInScreen, which returns NULL if not set, and add the same
conditional to WorkspaceLayoutManager2::OnWindowPropertyChanged.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/maximize_bubble_con...
File ash/wm/maximize_bubble_controller.h (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/maximize_bubble_con...
ash/wm/maximize_bubble_controller.h:87: // If true the owning window is
maximized.
Update description.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:504: restore =
*ash::GetRestoreBoundsInScreen(widget->GetNativeWindow());
This will crash if GetRestoreBoundsInScreen returns NULL.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:506:
ash::SetRestoreBoundsInScreen(widget->GetNativeWindow(),
Why do you need to set the restore bounds here as well as 514?

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:509: widget->Restore();
Gah. Looking at this whole branch it seems wrong. I think we should set the
frame to normal, then set the bounds.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:532: ) const {
Wrap FMB::GetMa.. to the next line, eg:
MaximizeBubbleFrameState
FrameMaximizeButton::GetMaximizeBubbleFrameState() const {
}

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:552: NOTREACHED();
Won't you hit this if you resize the window horizontally more than 50% of the
screen, then double click the vertical resize edge to fill screen?

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/maximize_...
File ash/wm/workspace/maximize_bubble_frame_state.h (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/maximize_...
ash/wm/workspace/maximize_bubble_frame_state.h:13: FRAME_STATE_FULL = 1,
At a minimum document that FULL == window is really maximized.

http://codereview.chromium.org/10883069/diff/14002/ui/views/widget/native_wid...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ui/views/widget/native_wid...
ui/views/widget/native_widget_aura.cc:589: /*
?

[Mr4D (OOO till 08-26), 2012-08-29 18:57:34]

Addressed. Please have another look!

http://codereview.chromium.org/10883069/diff/14002/ash/wm/base_layout_manager.cc
File ash/wm/base_layout_manager.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/base_layout_manager...
ash/wm/base_layout_manager.cc:140: GetRestoreBoundsInParent(window).IsEmpty() &&
On 2012/08/29 17:29:20, sky wrote:
> Use GetRestoreBoundsInScreen, which returns NULL if not set, and add the same
> conditional to WorkspaceLayoutManager2::OnWindowPropertyChanged.

Done.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/maximize_bubble_con...
File ash/wm/maximize_bubble_controller.h (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/maximize_bubble_con...
ash/wm/maximize_bubble_controller.h:87: // If true the owning window is
maximized.
On 2012/08/29 17:29:20, sky wrote:
> Update description.

Done.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:504: restore =
*ash::GetRestoreBoundsInScreen(widget->GetNativeWindow());
I thought that in maximized mode the restore rectangle HAS TO BE SET... No?
Added a DCHECK.
However I am a bit irritated now. Usually you want it to crash if something goes
wrong - and / or you do not want to check for obvious failures.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:506:
ash::SetRestoreBoundsInScreen(widget->GetNativeWindow(),
This is from the original code: We need to exit maximize and we have to 'revert'
to the left/right snapped locations.

The second one is then used for setting the real restore value so that we know
where to restore to when restore from snapped mode.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:509: widget->Restore();
This code predates my doing and was only taken over.

But... that is exactly what we do. Note that we do not want to set two different
sizes (normal, bounds) since that could cause a 'flash' or something when an
animation is used not/used.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:532: ) const {
On 2012/08/29 17:29:20, sky wrote:
> Wrap FMB::GetMa.. to the next line, eg:
> MaximizeBubbleFrameState
> FrameMaximizeButton::GetMaximizeBubbleFrameState() const {
> }

Done.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:552: NOTREACHED();
This state is still ominous to me and contradicts everything. I looked at the
code and see that it also populates the restore rect. I therefore removed that
NOTREACHED and added a comment that this case can happen - and why.

Note: This also required some other changes.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/maximize_...
File ash/wm/workspace/maximize_bubble_frame_state.h (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/maximize_...
ash/wm/workspace/maximize_bubble_frame_state.h:13: FRAME_STATE_FULL = 1,
I thought that was obvious. But added.

http://codereview.chromium.org/10883069/diff/14002/ui/views/widget/native_wid...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ui/views/widget/native_wid...
ui/views/widget/native_widget_aura.cc:589: /*
Daeng. I left that in while reverting all other changes for just in case if it
does not work and then forgot to remove it. Removed.

[sky, 2012-08-29 21:08:50]

LGTM

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
File ash/wm/workspace/frame_maximize_button.cc (right):

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:504: restore =
*ash::GetRestoreBoundsInScreen(widget->GetNativeWindow());
On 2012/08/29 18:57:34, Mr4D wrote:
> I thought that in maximized mode the restore rectangle HAS TO BE SET... No?
> Added a DCHECK.
> However I am a bit irritated now. Usually you want it to crash if something
goes
> wrong - and / or you do not want to check for obvious failures.

A DCHECK is the right thing. It says you expect this to be non-null.

http://codereview.chromium.org/10883069/diff/14002/ash/wm/workspace/frame_max...
ash/wm/workspace/frame_maximize_button.cc:509: widget->Restore();
On 2012/08/29 18:57:34, Mr4D wrote:
> This code predates my doing and was only taken over.
> 
> But... that is exactly what we do. Note that we do not want to set two
different
> sizes (normal, bounds) since that could cause a 'flash' or something when an
> animation is used not/used.

Good point.

[commit-bot: I haz the power, 2012-08-29 21:28:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10883069/23003

[commit-bot: I haz the power, 2012-08-29 23:26:11]

Try job failure for 10883069-23003 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-29 23:53:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10883069/23003

[commit-bot: I haz the power, 2012-08-30 02:59:34]

Try job failure for 10883069-23003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-30 03:26:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10883069/23003

[commit-bot: I haz the power, 2012-08-30 05:05:40]

Try job failure for 10883069-23003 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-30 14:25:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10883069/23003

[commit-bot: I haz the power, 2012-08-30 19:27:26]

Change committed as 154226

[commit-bot: I haz the power, 2012-08-30 20:04:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10883069/31002

[commit-bot: I haz the power, 2012-08-30 22:42:45]

Change committed as 154295

[commit-bot: I haz the power, 2012-08-31 01:52:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/10883069/41001

[commit-bot: I haz the power, 2012-08-31 04:18:40]

Change committed as 154372