Issue 10883031: Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10883031: Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup … (Closed)

Created:
8 years, 4 months ago by Cris Neckar

Modified:
8 years, 3 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup blocker checks. BUG=118317 TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153542

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	content/browser/web_contents/web_contents_impl.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

LGTM, provided that this doesn't change the style of tab that's created. http://codereview.chromium.org/10883031/diff/1/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc ...

8 years, 4 months ago (2012-08-24 21:30:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/10883031/3002

8 years, 3 months ago (2012-08-27 18:50:23 UTC) #3

Change committed as 153542

Expand Messages | Collapse Messages