Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 10883031: Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
===================================================================
--- content/browser/web_contents/web_contents_impl.cc (revision 153306)
+++ content/browser/web_contents/web_contents_impl.cc (working copy)
@@ -1284,8 +1284,10 @@
// When the opener is suppressed, the original renderer cannot access the
// new window. As a result, we need to show and navigate the window here.
gfx::Rect initial_pos;
+ // TODO(cdn) Fix popup white-listing for links that open in a new process.
AddNewContents(
- new_contents, params.disposition, initial_pos, params.user_gesture);
+ new_contents, params.user_gesture ? params.disposition : NEW_POPUP,
+ initial_pos, params.user_gesture);
content::OpenURLParams open_params(params.target_url, content::Referrer(),
CURRENT_TAB,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698