net: don't crash when processing a certificate with an unknown public key.

net: don't crash when processing a certificate with an unknown public key.

BUG=144466
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153220

[Ryan Sleevi, 2012-08-23 20:48:59]

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/cert_verif...
File net/base/cert_verify_proc_unittest.cc (right):

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/cert_verif...
net/base/cert_verify_proc_unittest.cc:233: Verify(cert,
"test2.imperialviolet.org", 0, NULL, &verify_result);
You should be able to use one of the existing auto-generated ECDSA certs - eg:
2048-rsa-ee-by-prime256v1-ecdsa

We disable these checks on Win XP (line 272 below), but you can still re-use the
data files.

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/cert_verif...
net/base/cert_verify_proc_unittest.cc:238: // crbug.com/144466).
Per the rest of the file, move the description of the test to right before the
TEST_F line (line 225)

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/x509_certi...
File net/base/x509_certificate_win.cc (right):

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/x509_certi...
net/base/x509_certificate_win.cc:441: CHECK(oid_info->dwGroupId ==
CRYPT_PUBKEY_ALG_OID_GROUP_ID);
nit: While you're here, CHECK_EQ ?

[Ryan Sleevi, 2012-08-23 20:49:38]

btw, LGTM mod nits above

[wtc, 2012-08-23 20:56:44]

Patch set 2 LGTM.

I verified that x509_certificate_{mac,nss}.cc already
handle errors.

If you decide to add net/data/ssl/certificates/ecdsa_rsa_test.pem,
please add a note about it in the README file in that
directory.

[agl, 2012-08-24 13:46:17]

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/cert_verif...
File net/base/cert_verify_proc_unittest.cc (right):

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/cert_verif...
net/base/cert_verify_proc_unittest.cc:233: Verify(cert,
"test2.imperialviolet.org", 0, NULL, &verify_result);
On 2012/08/23 20:48:59, Ryan Sleevi wrote:
> You should be able to use one of the existing auto-generated ECDSA certs - eg:
> 2048-rsa-ee-by-prime256v1-ecdsa

Thanks for pointing them out. Done.

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/cert_verif...
net/base/cert_verify_proc_unittest.cc:238: // crbug.com/144466).
On 2012/08/23 20:48:59, Ryan Sleevi wrote:
> Per the rest of the file, move the description of the test to right before the
> TEST_F line (line 225)

Done.

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/x509_certi...
File net/base/x509_certificate_win.cc (right):

https://chromiumcodereview.appspot.com/10883012/diff/3001/net/base/x509_certi...
net/base/x509_certificate_win.cc:441: CHECK(oid_info->dwGroupId ==
CRYPT_PUBKEY_ALG_OID_GROUP_ID);
On 2012/08/23 20:48:59, Ryan Sleevi wrote:
> nit: While you're here, CHECK_EQ ?

Done.

[commit-bot: I haz the power, 2012-08-24 13:47:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10883012/6003

[commit-bot: I haz the power, 2012-08-24 16:03:30]

Change committed as 153220